linux-kernel - Re: [PATCH v2 1/3] x86/entry: Clear extra registers beyond syscall arguments for 64bit kernels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180205155837.GK30338@tassilo.jf.intel.com>
Date:   Mon, 5 Feb 2018 07:58:37 -0800
From:   Andi Kleen <ak@...ux.intel.com>
To:     Ingo Molnar <mingo@...nel.org>
Cc:     Dan Williams <dan.j.williams@...el.com>, tglx@...utronix.de,
        x86@...nel.org, linux-kernel@...r.kernel.org,
        Ingo Molnar <mingo@...hat.com>, luto@...nel.org,
        "H. Peter Anvin" <hpa@...or.com>, torvalds@...ux-foundation.org
Subject: Re: [PATCH v2 1/3] x86/entry: Clear extra registers beyond syscall
 arguments for 64bit kernels

>      - There's various conditional pieces of entry code that run before any 
>        RBP-clobbering C function is called. While none of them has an exploitable 
>        Spectre 'gadget' at the moment, we'd have to consider this for every future
>        change.

The Frame Pointer is always set up in assembler too, just in another macro.

There should be only a few pushes between this clear and the set up,
which are not exploitable.

But yes in the end it doesn't matter much either way so the ifdef
could be removed for slightly nicer looking code.

-Andi