linux-kernel - Re: [RFC][PATCH] <linux/stringhash.h>: fix end_name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOQ4uxjEBji4G7o6ex1NYtR5jkunYg9kGByVXxiPhTSQBS8Big@mail.gmail.com>
Date:   Mon, 5 Feb 2018 20:35:21 +0200
From:   Amir Goldstein <amir73il@...il.com>
To:     Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     Al Viro <viro@...iv.linux.org.uk>,
        Miklos Szeredi <miklos@...redi.hu>,
        linux-fsdevel <linux-fsdevel@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [RFC][PATCH] <linux/stringhash.h>: fix end_name_hash() for 64bit long

On Mon, Feb 5, 2018 at 7:57 PM, Linus Torvalds
<torvalds@...ux-foundation.org> wrote:
> On Mon, Feb 5, 2018 at 9:51 AM, Amir Goldstein <amir73il@...il.com> wrote:
>>
>> and hash_32_generic() is just __hash_32() with zero shift.
>
> Right. But that __hash_32() is very expensive and doesn't help.
>
> So the patch as-is doesn't seem to buy anything, and only adds cost.

But my patch doesn't add any __hash_32() call. It was already there.
Anyway, I'll drop the patch.

Thanks,
Amir.