linux-kernel - Re: [PATCH] nospec: Move array_index_nospec parameter checking into separate macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPcyv4hd1sfYtwFdup8TLiJQCw_J3sUhOB2fEUW2Tr__Nyg2mw@mail.gmail.com>
Date:   Mon, 5 Feb 2018 10:54:34 -0800
From:   Dan Williams <dan.j.williams@...el.com>
To:     Will Deacon <will.deacon@....com>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...hat.com>
Subject: Re: [PATCH] nospec: Move array_index_nospec parameter checking into
 separate macro

On Mon, Feb 5, 2018 at 6:16 AM, Will Deacon <will.deacon@....com> wrote:
> For architectures providing their own implementation of
> array_index_mask_nospec in asm/barrier.h, attempting to use WARN_ONCE to
> complain about out-of-range parameters using WARN_ON results in a mess
> of mutually-dependent include files.
>
> Rather than unpick the dependencies, simply have the core code in nospec.h
> perform the checking for us.
>
> Cc: Dan Williams <dan.j.williams@...el.com>
> Cc: Ingo Molnar <mingo@...hat.com>
> Signed-off-by: Will Deacon <will.deacon@....com>

Looks ok to me and produces the same assembly.

Reviewed-by: Dan Williams <dan.j.williams@...el.com>