linux-kernel - Re: [PATCH] usb: dwc2: gadget: Use true and false for boolean values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <333168e1-f8b9-87bc-c6ba-a67c9112d686@synopsys.com>
Date:   Mon, 5 Feb 2018 13:12:49 -0800
From:   John Youn <John.Youn@...opsys.com>
To:     "Gustavo A. R. Silva" <gustavo@...eddedor.com>,
        John Youn <John.Youn@...opsys.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        <balbi@...nel.org>
CC:     "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Gustavo A. R. Silva" <garsilva@...eddedor.com>
Subject: Re: [PATCH] usb: dwc2: gadget: Use true and false for boolean values

On 01/23/2018 07:45 AM, Gustavo A. R. Silva wrote:
> Assign true or false to boolean variables instead of an integer value.
> 
> This issue was detected with the help of Coccinelle.
> 
> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
> ---
>   drivers/usb/dwc2/gadget.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c
> index e4c3ce0..1f684dd 100644
> --- a/drivers/usb/dwc2/gadget.c
> +++ b/drivers/usb/dwc2/gadget.c
> @@ -116,10 +116,10 @@ static inline void dwc2_gadget_incr_frame_num(struct dwc2_hsotg_ep *hs_ep)
>   {
>   	hs_ep->target_frame += hs_ep->interval;
>   	if (hs_ep->target_frame > DSTS_SOFFN_LIMIT) {
> -		hs_ep->frame_overrun = 1;
> +		hs_ep->frame_overrun = true;
>   		hs_ep->target_frame &= DSTS_SOFFN_LIMIT;
>   	} else {
> -		hs_ep->frame_overrun = 0;
> +		hs_ep->frame_overrun = false;
>   	}
>   }
>   
> 

+Felipe

Acked-by: John Youn <johnyoun@...opsys.com>

Regards,
John