linux-kernel - Re: [PATCH 3/3] vfio: disable filesystem-dax page pinning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPcyv4g+uC3HAnRpu-tfNdsBhon1dbXpte9P5DqWDBowoU08tw@mail.gmail.com>
Date:   Mon, 5 Feb 2018 14:01:53 -0800
From:   Dan Williams <dan.j.williams@...el.com>
To:     Alex Williamson <alex.williamson@...hat.com>
Cc:     Haozhong Zhang <haozhong.zhang@...el.com>,
        Michal Hocko <mhocko@...e.com>, Jan Kara <jack@...e.cz>,
        KVM list <kvm@...r.kernel.org>, linux-nvdimm@...ts.01.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        stable@...r.kernel.org,
        linux-fsdevel <linux-fsdevel@...r.kernel.org>,
        Christoph Hellwig <hch@....de>, aik@...abs.ru
Subject: Re: [PATCH 3/3] vfio: disable filesystem-dax page pinning

On Mon, Feb 5, 2018 at 1:44 PM, Alex Williamson
<alex.williamson@...hat.com> wrote:
> On Sun, 04 Feb 2018 15:05:30 -0800
> Dan Williams <dan.j.williams@...el.com> wrote:
>
>> Filesystem-DAX is incompatible with 'longterm' page pinning. Without
>> page cache indirection a DAX mapping maps filesystem blocks directly.
>> This means that the filesystem must not modify a file's block map while
>> any page in a mapping is pinned. In order to prevent the situation of
>> userspace holding of filesystem operations indefinitely, disallow
>> 'longterm' Filesystem-DAX mappings.
>>
>> RDMA has the same conflict and the plan there is to add a 'with lease'
>> mechanism to allow the kernel to notify userspace that the mapping is
>> being torn down for block-map maintenance. Perhaps something similar can
>> be put in place for vfio.
>>
>> Note that xfs and ext4 still report:
>>
>>    "DAX enabled. Warning: EXPERIMENTAL, use at your own risk"
>>
>> ...at mount time, and resolving the dax-dma-vs-truncate problem is one
>> of the last hurdles to remove that designation.
>>
>> Cc: Alex Williamson <alex.williamson@...hat.com>
>> Cc: Michal Hocko <mhocko@...e.com>
>> Cc: Christoph Hellwig <hch@....de>
>> Cc: kvm@...r.kernel.org
>> Cc: <stable@...r.kernel.org>
>> Reported-by: Haozhong Zhang <haozhong.zhang@...el.com>
>> Fixes: d475c6346a38 ("dax,ext2: replace XIP read and write with DAX I/O")
>> Signed-off-by: Dan Williams <dan.j.williams@...el.com>
>> ---
>>  drivers/vfio/vfio_iommu_type1.c |   18 +++++++++++++++---
>>  1 file changed, 15 insertions(+), 3 deletions(-)
>
> This isn't without some expense, a vfio mapping and un-mapping unit
> test incurs ~1.5% increase in system time losing access to gup_fast().
> Also, I think tce_iommu_use_page() is going to have the same problem, it
> provides the same sort of functionality for a different vfio IOMMU
> backend.  Please take this through your tree and I'll add a todo list
> item to see how we might improve this.
>
> Acked-by: Alex Williamson <alex.williamson@...hat.com>

Thanks Alex.