linux-kernel - Re: [PATCH 05/10] tools headers: Synchoronize x86 features UAPI headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180206105445.x3gqpaa3rwbnhugo@gmail.com>
Date:   Tue, 6 Feb 2018 11:54:45 +0100
From:   Ingo Molnar <mingo@...nel.org>
To:     David Woodhouse <dwmw2@...radead.org>
Cc:     Arnaldo Carvalho de Melo <acme@...nel.org>,
        linux-kernel@...r.kernel.org, linux-perf-users@...r.kernel.org,
        Arnaldo Carvalho de Melo <acme@...hat.com>,
        Adrian Hunter <adrian.hunter@...el.com>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        David Ahern <dsahern@...il.com>,
        Fenghua Yu <fenghua.yu@...el.com>,
        Jiri Olsa <jolsa@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        Paolo Bonzini <pbonzini@...hat.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Wang Nan <wangnan0@...wei.com>
Subject: Re: [PATCH 05/10] tools headers: Synchoronize x86 features UAPI
 headers


* David Woodhouse <dwmw2@...radead.org> wrote:

> 
> 
> On Mon, 2018-02-05 at 16:56 -0300, Arnaldo Carvalho de Melo wrote:
> > 
> > None will entail changes in the tools/perf/, synchronizing to elliminate
> > these perf build warnings:
> > 
> >   Warning: Kernel ABI header at 'tools/arch/x86/include/asm/disabled-features.h' differs from latest version at 'arch/x86/include/asm/disabled-features.h'
> >   Warning: Kernel ABI header at 'tools/arch/x86/include/asm/required-features.h' differs from latest version at 'arch/x86/include/asm/required-features.h'
> >   Warning: Kernel ABI header at 'tools/arch/x86/include/asm/cpufeatures.h' differs from latest version at 'arch/x86/include/asm/cpufeatures.h'
> 
> Ick. Have we considered just using a symlink? Why have copies of the
> same header file in different places in the tree, and tooling to
> complain i̶f̶when they get out of sync?

In the past we had incidents where kernel changes broke tooling and vice versa.

This is basically a soft-COW mechanism that decouples tooling source code from the 
kernel source code, while still having a technological mechanism in place that 
encourages the syncing of header files.

Thanks,

	Ingo