linux-kernel - Re: [PATCH 2/2] trace_uprobe: Simplify probes_seq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180206124739.GA57073@linux.vnet.ibm.com>
Date:   Tue, 6 Feb 2018 04:47:39 -0800
From:   Srikar Dronamraju <srikar@...ux.vnet.ibm.com>
To:     Ravi Bangoria <ravi.bangoria@...ux.vnet.ibm.com>
Cc:     rostedt@...dmis.org, mingo@...hat.com, oleg@...hat.com,
        wangnan0@...wei.com, masami.hiramatsu.pt@...achi.com,
        keescook@...omium.org, namhyung@...nel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] trace_uprobe: Simplify probes_seq_show()


> Simplify probes_seq_show() function. We are using %lx to display
> the offset and we don't prepend unnecessary 0s in the offset.
> 


The prepending of 0s was introduced by 
tracing/uprobes: Do not print '0x (null)' when offset is 0
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=a2fb3382

Wan, 
Was there a reason to prepend 0s?