linux-kernel - Re: [PATCH] perf test: Fix test trace+probe_libc_inet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180206135131.GA3451@kernel.org>
Date:   Tue, 6 Feb 2018 10:51:31 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Thomas Richter <tmricht@...ux.vnet.ibm.com>
Cc:     linux-kernel@...r.kernel.org, linux-perf-users@...r.kernel.org,
        brueckner@...ux.vnet.ibm.com, schwidefsky@...ibm.com,
        heiko.carstens@...ibm.com
Subject: Re: [PATCH] perf test: Fix test trace+probe_libc_inet_pton.sh for
 s390x

Em Wed, Jan 17, 2018 at 09:38:31AM +0100, Thomas Richter escreveu:
> On Intel test case trace+probe_libc_inet_pton.sh succeeds and the
> output is:
> [root@f27 perf]# ./perf trace --no-syscalls
>                   -e probe_libc:inet_pton/max-stack=3/ ping -6 -c 1 ::1
> PING ::1(::1) 56 data bytes
> 64 bytes from ::1: icmp_seq=1 ttl=64 time=0.037 ms
> 
>  --- ::1 ping statistics ---
> 1 packets transmitted, 1 received, 0% packet loss, time 0ms
> rtt min/avg/max/mdev = 0.037/0.037/0.037/0.000 ms
>      0.000 probe_libc:inet_pton:(7fa40ac618a0))
>               __GI___inet_pton (/usr/lib64/libc-2.26.so)
>               getaddrinfo (/usr/lib64/libc-2.26.so)
>               main (/usr/bin/ping)
> 
> The kernel stack unwinder is used, it is specified implicitly
> as call-graph=fp (frame pointer).
> 
> On s390x only dwarf is available for stack unwinding. It is also
> done in user space. This requires different parameter setup
> and result checking for s390x and Intel.

Thanks, looks sane, tested on x86_64, applied.

Do you have some other patches outstanding that I should look? I
travelled a bit, so trying to catch up on patches submitted.

Thanks again,

- Arnaldo