linux-kernel - Re: [RFC] tracing: Improve design of preemptirq tracepoints and its users

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180206092705.49445560@gandalf.local.home>
Date:   Tue, 6 Feb 2018 09:27:05 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Joel Fernandes <joelaf@...gle.com>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Peter Zilstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
        Tom Zanussi <tom.zanussi@...ux.intel.com>,
        Namhyung Kim <namhyung@...nel.org>,
        "Cc: Android Kernel" <kernel-team@...roid.com>
Subject: Re: [RFC] tracing: Improve design of preemptirq tracepoints and its
 users

On Mon, 5 Feb 2018 23:15:32 -0800
Joel Fernandes <joelaf@...gle.com> wrote:

> On Mon, Feb 5, 2018 at 6:39 PM, Joel Fernandes <joelaf@...gle.com> wrote:
> > This patch detaches the preemptirq tracepoints from the tracers and
> > keeps it separate. With this, several ifdefs are cleaner, and lockdep
> > and other users can use the preemptirq tracepoints by registering probes
> > onto them. This makes it much cleaner, but not just that: PROVE_LOCKING
> > and CONFIG_IRQSOFF_TRACER can be enabled now at the same time and we
> > get rid of all the horrific ifdeferry around PROVE_LOCKING.
> >  
> 
> Sorry for the misstatement, irqsoff tracer and PROVE_LOCKING can still
> be used at the same time (without this patch). I will correct the
> commit message in the next rev. However this patch avoids the
> complication that arises when enabling the 2 together, by eliminating
> time_hardirqs_on/off.
> 

Hi Joel,

This looks nice, but I currently don't have time to look at it. Please
ping me again if you don't hear from me by beginning of next week.

-- Steve