linux-kernel - Re: [PATCH][btrfs-next] btrfs: remove redundant check on ret and goto

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180206144442.GA31890@twin.jikos.cz>
Date:   Tue, 6 Feb 2018 15:44:42 +0100
From:   David Sterba <dsterba@...e.cz>
To:     Colin King <colin.king@...onical.com>
Cc:     Chris Mason <clm@...com>, Josef Bacik <jbacik@...com>,
        David Sterba <dsterba@...e.com>, Liu Bo <bo.li.liu@...cle.com>,
        linux-btrfs@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH][btrfs-next] btrfs: remove redundant check on ret and goto

On Fri, Jan 12, 2018 at 04:52:58PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> The check for a non-zero ret is redundant as the goto will jump to
> the very next statement anyway.  Remove this extraneous code.
> 
> Detected by CoverityScan, CID#1463784 ("Identical code for different
> branches")
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Added to next, thanks.