linux-kernel - Re: [PATCH] crypto: s5p-sss.c: Fix kernel Oops in AES-ECB mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 6 Feb 2018 22:18:26 +0530
From:   Anand Moon <linux.amoon@...il.com>
To:     Kamil Konieczny <k.konieczny@...tner.samsung.com>
Cc:     Herbert Xu <herbert@...dor.apana.org.au>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Vladimir Zapolskiy <vz@...ia.com>,
        "David S. Miller" <davem@...emloft.net>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        Marek Szyprowski <m.szyprowski@...sung.com>,
        linux-crypto@...r.kernel.org, linux-samsung-soc@...r.kernel.org,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] crypto: s5p-sss.c: Fix kernel Oops in AES-ECB mode

Hi Kamil,

Thanks for providing the fix to this issue.

On 5 February 2018 at 23:10, Kamil Konieczny
<k.konieczny@...tner.samsung.com> wrote:
>
> In AES-ECB mode crypt is done with key only, so any use of IV
> can cause kernel Oops, as reported by Anand Moon.

If possible could you avoid the name in commit message.

> Fixed it by using IV only in AES-CBC and AES-CTR.
>
> Signed-off-by: Kamil Konieczny <k.konieczny@...tner.samsung.com>
> Reported-by: Anand Moon <linux.amoon@...il.com>

[snip]

Please add my. Tested on Odroid HC2

Tested-by: Anand Moon <linux.amoon@...il.com>

Below are the result at my end.

aes-cbc-essiv:sha256 (128 bit key)
WRITE:
100+0 records in
100+0 records out
838860800 bytes (839 MB, 800 MiB) copied, 11.7225 s, 71.6 MB/s
READ:
100+0 records in
100+0 records out
838860800 bytes (839 MB, 800 MiB) copied, 22.112 s, 37.9 MB/s

aes-cbc-essiv:sha256 (256 bit key)
WRITE:
100+0 records in
100+0 records out
838860800 bytes (839 MB, 800 MiB) copied, 13.096 s, 64.1 MB/s
READ:
100+0 records in
100+0 records out
838860800 bytes (839 MB, 800 MiB) copied, 24.4165 s, 34.4 MB/s

aes-ctr-plain (128 bit key)
WRITE:
100+0 records in
100+0 records out
838860800 bytes (839 MB, 800 MiB) copied, 11.2246 s, 74.7 MB/s
READ:
100+0 records in
100+0 records out
838860800 bytes (839 MB, 800 MiB) copied, 20.426 s, 41.1 MB/s

aes-xts-plain64 (256 bit key)
WRITE:
100+0 records in
100+0 records out
838860800 bytes (839 MB, 800 MiB) copied, 11.1533 s, 75.2 MB/s
READ:
100+0 records in
100+0 records out
838860800 bytes (839 MB, 800 MiB) copied, 20.8821 s, 40.2 MB/s

aes-xts-plain64 (512 bit key)
WRITE:
100+0 records in
100+0 records out
838860800 bytes (839 MB, 800 MiB) copied, 12.0614 s, 69.5 MB/s
READ:
100+0 records in
100+0 records out
838860800 bytes (839 MB, 800 MiB) copied, 23.0717 s, 36.4 MB/s

twofish-cbc-essiv:sha256 (128 bit key)
WRITE:
100+0 records in
100+0 records out
838860800 bytes (839 MB, 800 MiB) copied, 13.031 s, 64.4 MB/s
READ:
100+0 records in
100+0 records out
838860800 bytes (839 MB, 800 MiB) copied, 20.7202 s, 40.5 MB/s

twofish-cbc-essiv:sha256 (256 bit key)
WRITE:
100+0 records in
100+0 records out
838860800 bytes (839 MB, 800 MiB) copied, 12.9995 s, 64.5 MB/s
READ:
100+0 records in
100+0 records out
838860800 bytes (839 MB, 800 MiB) copied, 24.2369 s, 34.6 MB/s

twofish-xts-plain64 (256 bit key)
WRITE:
100+0 records in
100+0 records out
838860800 bytes (839 MB, 800 MiB) copied, 14.607 s, 57.4 MB/s
READ:
100+0 records in
100+0 records out
838860800 bytes (839 MB, 800 MiB) copied, 26.2963 s, 31.9 MB/s

twofish-xts-plain64 (512 bit key)
WRITE:
100+0 records in
100+0 records out
838860800 bytes (839 MB, 800 MiB) copied, 14.5783 s, 57.5 MB/s
READ:
100+0 records in
100+0 records out
838860800 bytes (839 MB, 800 MiB) copied, 25.3593 s, 33.1 MB/s

serpent-cbc-essiv:sha256 (128 bit key)
WRITE:
100+0 records in
100+0 records out
838860800 bytes (839 MB, 800 MiB) copied, 15.5157 s, 54.1 MB/s
READ:
100+0 records in
100+0 records out
838860800 bytes (839 MB, 800 MiB) copied, 37.0526 s, 22.6 MB/s

serpent-cbc-essiv:sha256 (256 bit key)
WRITE:
100+0 records in
100+0 records out
838860800 bytes (839 MB, 800 MiB) copied, 16.1138 s, 52.1 MB/s
READ:
100+0 records in
100+0 records out
838860800 bytes (839 MB, 800 MiB) copied, 36.922 s, 22.7 MB/s

serpent-xts-plain64 (256 bit key)
WRITE:
100+0 records in
100+0 records out
838860800 bytes (839 MB, 800 MiB) copied, 17.287 s, 48.5 MB/s
READ:
100+0 records in
100+0 records out
838860800 bytes (839 MB, 800 MiB) copied, 39.279 s, 21.4 MB/s

serpent-xts-plain64 (512 bit key)
WRITE:
100+0 records in
100+0 records out
838860800 bytes (839 MB, 800 MiB) copied, 16.9464 s, 49.5 MB/s
READ:
100+0 records in
100+0 records out
838860800 bytes (839 MB, 800 MiB) copied, 38.3389 s, 21.9 MB/s

Best Regards
-Anand