linux-kernel - Re: [PATCH 1/2] char_dev: Fix off-by-one bugs in find_dynamic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <de9e2460-3633-ee4b-904d-6510f9045b8b@deltatee.com>
Date:   Tue, 6 Feb 2018 10:14:53 -0700
From:   Logan Gunthorpe <logang@...tatee.com>
To:     "Srivatsa S. Bhat" <srivatsa@...il.mit.edu>,
        gregkh@...uxfoundation.org
Cc:     axboe@...nel.dk, jlayton@...chiereds.net, bfields@...ldses.org,
        viro@...iv.linux.org.uk, linux-fsdevel@...r.kernel.org,
        linux-block@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] char_dev: Fix off-by-one bugs in find_dynamic_major()

Thanks!

On 05/02/18 07:25 PM, Srivatsa S. Bhat wrote:
> From: Srivatsa S. Bhat <srivatsa@...il.mit.edu>
> 
> CHRDEV_MAJOR_DYN_END and CHRDEV_MAJOR_DYN_EXT_END are valid major
> numbers. So fix the loop iteration to include them in the search for
> free major numbers.
> 
> While at it, also remove a redundant if condition ("cd->major != i"),
> as it will never be true.
> 
> Signed-off-by: Srivatsa S. Bhat <srivatsa@...il.mit.edu>

Reviewed-by: Logan Gunthorpe <logang@...tatee.com>


Logan