linux-kernel - Re: [PATCH] printk: Print error pointers as negative integers for %p

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75Vd4i+=xyM80beqznuQbqwp_VSVOi0=-44u7WGpkVvw7mw@mail.gmail.com>
Date:   Tue, 6 Feb 2018 20:51:58 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     David Howells <dhowells@...hat.com>
Cc:     Linus Torvalds <torvalds@...ux-foundation.org>,
        "Peter Zijlstra (Intel)" <peterz@...radead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "Tobin C. Harding" <me@...in.cc>
Subject: Re: [PATCH] printk: Print error pointers as negative integers for %p

On Tue, Feb 6, 2018 at 11:21 AM, David Howells <dhowells@...hat.com> wrote:
> The new hashing feature of unadorned printk("%p") makes it hard to spot if
> the pointer actually carries an error value.  Make %p print any pointer
> that matches IS_ERR() as a negative integer.
>
> Should I set SMALL and the field_width as well, I wonder?

> +               spec.type = FORMAT_TYPE_INT;

_LONG ?

For sake of consistency.

-- 
With Best Regards,
Andy Shevchenko