linux-kernel - RE: [RFC, PATCH v1] platform/x86: intel-vbtn: Convert to pure ACPI driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c51e36664a6e4df6b641f3c684b0d189@ausx13mpc120.AMER.DELL.COM>
Date:   Tue, 6 Feb 2018 20:33:54 +0000
From:   <Mario.Limonciello@...l.com>
To:     <andriy.shevchenko@...ux.intel.com>, <dvhart@...radead.org>
CC:     <platform-driver-x86@...r.kernel.org>, <acelan.kao@...onical.com>,
        <linux-kernel@...r.kernel.org>, <pali.rohar@...il.com>,
        <rjw@...ysocki.net>
Subject: RE: [RFC, PATCH v1] platform/x86: intel-vbtn: Convert to pure ACPI
 driver

> -----Original Message-----
> From: platform-driver-x86-owner@...r.kernel.org [mailto:platform-driver-x86-
> owner@...r.kernel.org] On Behalf Of Andy Shevchenko
> Sent: Monday, February 5, 2018 10:18 AM
> To: Darren Hart <dvhart@...radead.org>
> Cc: platform-driver-x86@...r.kernel.org; AceLan Kao
> <acelan.kao@...onical.com>; linux-kernel@...r.kernel.org;
> pali.rohar@...il.com; Limonciello, Mario <Mario_Limonciello@...l.com>; Rafael
> Wysocki <rjw@...ysocki.net>
> Subject: Re: [RFC, PATCH v1] platform/x86: intel-vbtn: Convert to pure ACPI driver
> 
> On Wed, 2018-01-31 at 13:37 -0800, Darren Hart wrote:
> > On Wed, Jan 31, 2018 at 08:26:14PM +0200, Andy Shevchenko wrote:
> > > Remove code duplication by converting driver to pure ACPI one.
> >
> 
> I have fixed couple issues, but...
> 
> > +Rafael
> >
> > I don't see any reason *not* to do this, it seems the acpi driver
> > model provides
> > some of the boilerplate stuff we were doing manually before as a
> > platform
> > device. I'm scratching my head wondering why we did this as a
> > platform-driver in
> > the first place now...
> 
> ...I still keep in my review queue in a hope that someone can actually
> test this on real hardware.
> 
> --
> Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> Intel Finland Oy

Andy,

I'm pretty sure XPS 9365 can test this.  I was going to try but 
https://patchwork.kernel.org/patch/10194503/ was not
able to compile on top of platform-x86/for-next.
That was the only one I saw at patchwork.

drivers/platform/x86/intel-vbtn.c:172:11: error: ‘ACPI_BUTTON_CLASS’ undeclared here (not in a function)
  .class = ACPI_BUTTON_CLASS,
           ^
drivers/platform/x86/intel-vbtn.c:178:2: error: unknown field ‘driver’ specified in initializer
  .driver = {
  ^
scripts/Makefile.build:316: recipe for target 'drivers/platform/x86/intel-vbtn.o' failed
make[5]: *** [drivers/platform/x86/intel-vbtn.o] Error 1

is that different than the one in your review queue?

Thanks,