linux-kernel - Re: [RESEND PATCH] rtc: Fix overflow when converting time64_t to rtc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMz4kuLPsF-aeK9uEeeBd1irz0CPVGhR=wYEtkYM1-3Ktzb1Dg@mail.gmail.com>
Date:   Tue, 6 Feb 2018 12:00:26 +0800
From:   Baolin Wang <baolin.wang@...aro.org>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Alessandro Zummo <a.zummo@...ertech.it>,
        Alexandre Belloni <alexandre.belloni@...e-electrons.com>,
        Mark Brown <broonie@...nel.org>, linux-rtc@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [RESEND PATCH] rtc: Fix overflow when converting time64_t to rtc_time

Hi Alexandre,

On 26 January 2018 at 17:24, Arnd Bergmann <arnd@...db.de> wrote:
> On Fri, Jan 26, 2018 at 6:06 AM, Baolin Wang <baolin.wang@...aro.org> wrote:
>> If we convert one large time values to rtc_time, in the original formula
>> 'days * 86400' can be overflowed in 'unsigned int' type to make the formula
>> get one incorrect remain seconds value. Thus we can use div_s64_rem()
>> function to avoid this situation.
>>
>> Signed-off-by: Baolin Wang <baolin.wang@...aro.org>
>
> Acked-by: Arnd Bergmann <arnd@...db.de>

Could you apply this patch? Since it was pending for a while and it is
a bug fix. Thanks.

-- 
Baolin.wang
Best Regards