linux-kernel - Re: [PATCH] scsi: qedf: remove redundant initialization of 'fcport'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.OSX.2.00.1802061658320.3555@administrators-MacBook-Pro.local>
Date:   Tue, 6 Feb 2018 16:58:53 -0500 (EST)
From:   Chad Dupuis <chad.dupuis@...ium.com>
To:     Colin King <colin.king@...onical.com>
cc:     QLogic-Storage-Upstream@...ium.com,
        "James E . J . Bottomley" <jejb@...ux.vnet.ibm.com>,
        "Martin K . Petersen" <martin.petersen@...cle.com>,
        linux-scsi@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: qedf: remove redundant initialization of
 'fcport'


On Tue, 6 Feb 2018, 9:03am, Colin King wrote:

> From: Colin Ian King <colin.king@...onical.com>
> 
> Pointer fcport is initialized with a value that is never read, it is
> re-assigned a new value later on, hence the initialization is redundant
> and can be removed.
> 
> Cleans up clang warning:
> drivers/scsi/qedf/qedf_io.c:920:21: warning: Value stored to 'fcport'
> during its initialization is never read
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  drivers/scsi/qedf/qedf_io.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/qedf/qedf_io.c b/drivers/scsi/qedf/qedf_io.c
> index b15e69586a36..50a50c4249d0 100644
> --- a/drivers/scsi/qedf/qedf_io.c
> +++ b/drivers/scsi/qedf/qedf_io.c
> @@ -917,7 +917,7 @@ qedf_queuecommand(struct Scsi_Host *host, struct scsi_cmnd *sc_cmd)
>  	struct qedf_ctx *qedf = lport_priv(lport);
>  	struct fc_rport *rport = starget_to_rport(scsi_target(sc_cmd->device));
>  	struct fc_rport_libfc_priv *rp = rport->dd_data;
> -	struct qedf_rport *fcport = rport->dd_data;
> +	struct qedf_rport *fcport;
>  	struct qedf_ioreq *io_req;
>  	int rc = 0;
>  	int rval;
> 

Acked-by: Chad Dupuis <chad.dupuis@...ium.com>