linux-kernel - Re: [PATCH] staging: android: ion: minor cleanup for ion_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <19448c54-7214-ce7c-1ae0-9e8605e34f2c@redhat.com>
Date:   Tue, 6 Feb 2018 14:51:19 -0800
From:   Laura Abbott <labbott@...hat.com>
To:     Yisheng Xie <xieyisheng1@...wei.com>, gregkh@...uxfoundation.org
Cc:     sumit.semwal@...aro.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: android: ion: minor cleanup for ion_page_pool

On 01/31/2018 01:50 AM, Yisheng Xie wrote:
> ion_page_pool.c now is used to apply pool APIs for system heap, which do
> not need do any initial at device_initcall.
> 
> Meanwhile, this patch also remove some useless include files.
> 

Acked-by: Laura Abbott <labbott@...hat.com>

> Signed-off-by: Yisheng Xie <xieyisheng1@...wei.com>
> ---
>   drivers/staging/android/ion/ion_page_pool.c | 11 -----------
>   1 file changed, 11 deletions(-)
> 
> diff --git a/drivers/staging/android/ion/ion_page_pool.c b/drivers/staging/android/ion/ion_page_pool.c
> index 817849d..3c1eba5 100644
> --- a/drivers/staging/android/ion/ion_page_pool.c
> +++ b/drivers/staging/android/ion/ion_page_pool.c
> @@ -14,12 +14,7 @@
>    *
>    */
>   
> -#include <linux/debugfs.h>
> -#include <linux/dma-mapping.h>
> -#include <linux/err.h>
> -#include <linux/fs.h>
>   #include <linux/list.h>
> -#include <linux/init.h>
>   #include <linux/slab.h>
>   #include <linux/swap.h>
>   
> @@ -171,9 +166,3 @@ void ion_page_pool_destroy(struct ion_page_pool *pool)
>   {
>   	kfree(pool);
>   }
> -
> -static int __init ion_page_pool_init(void)
> -{
> -	return 0;
> -}
> -device_initcall(ion_page_pool_init);
>