linux-kernel - Re: [PATCH tip-pti 1/2] x86/entry: remove SAVE_C_REGS_EXCEPT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFwuBi8xTNk8Qe+Hw+4z07GPqAq40mYiiR3V71v_EDzhfw@mail.gmail.com>
Date:   Tue, 6 Feb 2018 14:56:11 -0800
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Dominik Brodowski <linux@...inikbrodowski.net>
Cc:     Ingo Molnar <mingo@...nel.org>,
        Dan Williams <dan.j.williams@...el.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Andi Kleen <ak@...ux.intel.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Andrew Lutomirski <luto@...nel.org>,
        "the arch/x86 maintainers" <x86@...nel.org>
Subject: Re: [PATCH tip-pti 1/2] x86/entry: remove SAVE_C_REGS_EXCEPT_* macros

On Tue, Feb 6, 2018 at 1:25 PM, Dominik Brodowski
<linux@...inikbrodowski.net> wrote:
> The macros which save all but specific registers have been unused for
> a long time. Remove them and the SAVE_C_REGS_HELPER macro, but
> instead provide the SAVE_C_REGS macro directly.

Ack. But see my other email about even more cleanups.

At least the SAVE_{C,EXTRA}_REGS -> SAVE_REGS combination cleanup
should be totally mindless, since they are always used together and
with the same argument.

Unless I'm blind.

           Linus