linux-kernel - Re: [PATCH 2/2] staging: android: ion: Remove lable debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6fa110ed-afab-b707-a2e9-7a1a94ccf92f@redhat.com>
Date:   Tue, 6 Feb 2018 15:00:22 -0800
From:   Laura Abbott <labbott@...hat.com>
To:     Yisheng Xie <xieyisheng1@...wei.com>, gregkh@...uxfoundation.org
Cc:     sumit.semwal@...aro.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] staging: android: ion: Remove lable debugfs_done

On 02/01/2018 04:34 AM, Yisheng Xie wrote:
> When failed to create debug_root, we will go on initail other part of
> ion, so we can just info this message to user and do not need a lable
> to jump.
> 

Acked-by: Laura Abbott <labbott@...hat.com>

> Signed-off-by: Yisheng Xie <xieyisheng1@...wei.com>
> ---
>   drivers/staging/android/ion/ion.c | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c
> index 3e41644..70a70f5 100644
> --- a/drivers/staging/android/ion/ion.c
> +++ b/drivers/staging/android/ion/ion.c
> @@ -601,12 +601,9 @@ static int ion_device_create(void)
>   	}
>   
>   	idev->debug_root = debugfs_create_dir("ion", NULL);
> -	if (!idev->debug_root) {
> +	if (!idev->debug_root)
>   		pr_err("ion: failed to create debugfs root directory.\n");
> -		goto debugfs_done;
> -	}
>   
> -debugfs_done:
>   	idev->buffers = RB_ROOT;
>   	mutex_init(&idev->buffer_lock);
>   	init_rwsem(&idev->lock);
>