linux-kernel - Re: [PATCH 1/2] trace-cmd: Fix the detection for swig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180206181807.2d35393e@gandalf.local.home>
Date:   Tue, 6 Feb 2018 18:18:07 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     sztsian@...il.com
Cc:     johannes.berg@...el.com, johannes@...solutions.net,
        linux-kernel@...r.kernel.org, zsun@...hat.com,
        Vladislav Valtchev <vladislav.valtchev@...il.com>
Subject: Re: [PATCH 1/2] trace-cmd: Fix the detection for swig

On Sun,  4 Feb 2018 11:20:13 +0800
sztsian@...il.com wrote:

> From: Zamir SUN <sztsian@...il.com>
> 
> The current detection for swig will cause output to be
> /usr/bin/swig
> y
> So this will never be equal to y. With this patch, the swig path is
> removed from output, so the detection can work as expected.
> 
> Fixes 3bf187a43b7e6302592552ecbc294e5820249687

Hi Zamir,

Actually, a fix was already sent to me:

 http://lkml.kernel.org/r/20171220180748.17273-18-vladislav.valtchev@gmail.com

I'm working on add that one.

Thanks!

-- Steve

 
> 
> Signed-off-by: Zamir SUN (Red Hat) <sztsian@...il.com>
> ---
>  Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Makefile b/Makefile
> index a5d2c38..7c0d1a6 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -105,7 +105,7 @@ PYTHON_GUI	:= ctracecmd.so ctracecmdgui.so
>  PYTHON_VERS ?= python
>  
>  # Can build python?
> -ifeq ($(shell sh -c "pkg-config --cflags $(PYTHON_VERS) > /dev/null 2>&1 && which swig && echo y"), y)
> +ifeq ($(shell sh -c "pkg-config --cflags $(PYTHON_VERS) > /dev/null 2>&1 && which swig > /dev/null && echo y"), y)
>  	PYTHON_PLUGINS := plugin_python.so
>  	BUILD_PYTHON := $(PYTHON) $(PYTHON_PLUGINS)
>  	PYTHON_SO_INSTALL := ctracecmd.install