linux-kernel - Re: [PATCH] ALSA: usb-audio: Fix UAC2 get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 07 Feb 2018 06:45:49 +0100
From:   Takashi Iwai <tiwai@...e.de>
To:     "Kirill Marinushkin" <k.marinushkin@...il.com>
Cc:     <perex@...ex.cz>, <alsa-devel@...a-project.org>,
        "Stephen Barber" <smbarber@...omium.org>,
        "Bhumika Goyal" <bhumirks@...il.com>,
        "Jaejoong Kim" <climbbb.kim@...il.com>,
        "Julian Scheel" <julian@...st.de>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ALSA: usb-audio: Fix UAC2 get_ctl request with a RANGE attribute

On Mon, 29 Jan 2018 06:37:55 +0100,
Kirill Marinushkin wrote:
> 
> The layout of the UAC2 Control request and response varies depending on
> the request type. With the current implementation, only the Layout 2
> Parameter Block (with the 2-byte sized RANGE attribute) is handled
> properly. For the Control requests with the 1-byte sized RANGE attribute
> (Bass Control, Mid Control, Tremble Control), the response is parsed
> incorrectly.
> 
> This commit:
> * fixes the wLength field value in the request
> * fixes parsing the range values from the response
> 
> Fixes: 23caaf19b11e ("ALSA: usb-mixer: Add support for Audio Class v2.0")
> Signed-off-by: Kirill Marinushkin <k.marinushkin@...il.com>
> Cc: Jaroslav Kysela <perex@...ex.cz>
> Cc: Takashi Iwai <tiwai@...e.com>
> Cc: Jaejoong Kim <climbbb.kim@...il.com>
> Cc: Bhumika Goyal <bhumirks@...il.com>
> Cc: Stephen Barber <smbarber@...omium.org>
> Cc: Julian Scheel <julian@...st.de>
> Cc: alsa-devel@...a-project.org
> Cc: linux-kernel@...r.kernel.org

Sorry for the late reply, as I've been (and still) off.

Does this bug actually hit on any real devices, or is it only a
logical error so far?  In the former case, a Cc to stable is
mandatory.

In anyway, I'll review and merge it properly once after I back to
work.


thanks,

Takashi