linux-kernel - Re: [PATCH] char: rtc: remove unused rtc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180207010422.GU3404@piout.net>
Date:   Wed, 7 Feb 2018 02:04:22 +0100
From:   Alexandre Belloni <alexandre.belloni@...tlin.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] char: rtc: remove unused rtc_control() API

On 07/02/2018 at 00:24:11 +0100, Arnd Bergmann wrote:
> On Tue, Feb 6, 2018 at 11:12 PM, Alexandre Belloni
> <alexandre.belloni@...tlin.com> wrote:
> > Since commit 34ce71a96dcb ("ALSA: timer: remove legacy rtctimer"), the
> > rtc_register/rtc_control/rtc_unregister API is unused. As it is highly
> > unlikely to be needed again, remove it.
> >
> > Signed-off-by: Alexandre Belloni <alexandre.belloni@...tlin.com>
> > ---
> 
> Nice!
> 
> Acked-by: Arnd Bergmann <arnd@...db.de>
> 
> I forgot what's stopping us from removing the rest of that driver ;-)
> Since we can only build it on alpha and mips/loongson64 these
> days, is there anything that this driver does that the normal
> one doesn't? If it's just a question of testing, we could probably
> just move it to staging and see if anyone notices a difference.

I'd say it is a matter of testing. The loongsoon maintainers seem
responsive so we may get testing for that architecture. I'm not so sure
about alpha. Actually, I'm not even sure it is really used on alpha
because arch/alpha/kernel/rtc.c seems to do the right thing.

I think I'll start by ripping of all the x86 and sparc specific parts
and see what's left.

I would also love to get rid of drivers/char/efirtc.c but that probably
means doing some testing on both an ARM/ARM64 platform with EFI and
IA64.


-- 
Alexandre Belloni, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com