linux-kernel - Re: [RFC PATCH v4 1/2] fuse: introduce new fs_type flag FS_IMA_NO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 7 Feb 2018 10:21:29 +0100
From:   Miklos Szeredi <miklos@...redi.hu>
To:     Dongsu Park <dongsu@...volk.io>
Cc:     linux-kernel@...r.kernel.org,
        linux-integrity <linux-integrity@...r.kernel.org>,
        LSM <linux-security-module@...r.kernel.org>,
        linux-fsdevel@...r.kernel.org, Alban Crequy <alban@...volk.io>,
        Miklos Szeredi <mszeredi@...hat.com>,
        Alexander Viro <viro@...iv.linux.org.uk>,
        Mimi Zohar <zohar@...ux.vnet.ibm.com>,
        Dmitry Kasatkin <dmitry.kasatkin@...il.com>,
        James Morris <jmorris@...ei.org>,
        Christoph Hellwig <hch@...radead.org>,
        "Serge E . Hallyn" <serge@...lyn.com>,
        Seth Forshee <seth.forshee@...onical.com>
Subject: Re: [RFC PATCH v4 1/2] fuse: introduce new fs_type flag FS_IMA_NO_CACHE

On Tue, Jan 30, 2018 at 7:06 PM, Dongsu Park <dongsu@...volk.io> wrote:
> From: Alban Crequy <alban@...volk.io>
>
> This new fs_type flag FS_IMA_NO_CACHE means files should be re-measured,
> re-appraised and re-audited each time. Cached integrity results should
> not be used.
>
> It is useful in FUSE because the userspace FUSE process can change the
> underlying files at any time without notifying the kernel.
>
> Cc: linux-kernel@...r.kernel.org
> Cc: linux-integrity@...r.kernel.org
> Cc: linux-security-module@...r.kernel.org
> Cc: linux-fsdevel@...r.kernel.org
> Cc: Miklos Szeredi <miklos@...redi.hu>
> Cc: Alexander Viro <viro@...iv.linux.org.uk>
> Cc: Mimi Zohar <zohar@...ux.vnet.ibm.com>
> Cc: Dmitry Kasatkin <dmitry.kasatkin@...il.com>
> Cc: James Morris <jmorris@...ei.org>
> Cc: Christoph Hellwig <hch@...radead.org>
> Acked-by: "Serge E. Hallyn" <serge@...lyn.com>
> Acked-by: Seth Forshee <seth.forshee@...onical.com>
> Tested-by: Dongsu Park <dongsu@...volk.io>
> Signed-off-by: Alban Crequy <alban@...volk.io>
> ---
>  fs/fuse/inode.c    | 2 +-
>  include/linux/fs.h | 1 +
>  2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/fs/fuse/inode.c b/fs/fuse/inode.c
> index 624f18bb..0a9e5164 100644
> --- a/fs/fuse/inode.c
> +++ b/fs/fuse/inode.c
> @@ -1205,7 +1205,7 @@ static void fuse_kill_sb_anon(struct super_block *sb)
>  static struct file_system_type fuse_fs_type = {
>         .owner          = THIS_MODULE,
>         .name           = "fuse",
> -       .fs_flags       = FS_HAS_SUBTYPE,
> +       .fs_flags       = FS_HAS_SUBTYPE | FS_IMA_NO_CACHE,
>         .mount          = fuse_mount,
>         .kill_sb        = fuse_kill_sb_anon,
>  };
> diff --git a/include/linux/fs.h b/include/linux/fs.h
> index 511fbaab..ced841ba 100644
> --- a/include/linux/fs.h
> +++ b/include/linux/fs.h
> @@ -2075,6 +2075,7 @@ struct file_system_type {
>  #define FS_BINARY_MOUNTDATA    2
>  #define FS_HAS_SUBTYPE         4
>  #define FS_USERNS_MOUNT                8       /* Can be mounted by userns root */
> +#define FS_IMA_NO_CACHE                16      /* Force IMA to re-measure, re-appraise, re-audit files */

I think it would be more logical to change the order of the patches
(i.e. first patch adds this constant and the code handling it, and
second patch just adds it to fuse's .fs_flags).

Otherwise

Acked-by:   Miklos Szeredi <mszeredi@...hat.com>

Thanks,
Miklos


>  #define FS_RENAME_DOES_D_MOVE  32768   /* FS will handle d_move() during rename() internally. */
>         struct dentry *(*mount) (struct file_system_type *, int,
>                        const char *, void *);
> --
> 2.13.6
>