linux-kernel - Re: [PATCH v2 15/15] ARM: dts: dra7: Add high speed modes capability to MMC1/MMC2 dt node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b411cf11-61e9-e688-6f04-e624fe52ac66@ti.com>
Date:   Wed, 7 Feb 2018 14:51:57 +0530
From:   Kishon Vijay Abraham I <kishon@...com>
To:     Sekhar Nori <nsekhar@...com>,
        Benoît Cousson <bcousson@...libre.com>,
        Tony Lindgren <tony@...mide.com>,
        Rob Herring <robh+dt@...nel.org>
CC:     Mark Rutland <mark.rutland@....com>,
        Russell King <linux@...linux.org.uk>,
        <linux-omap@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 15/15] ARM: dts: dra7: Add high speed modes capability
 to MMC1/MMC2 dt node

Hi,

On Wednesday 07 February 2018 02:41 PM, Sekhar Nori wrote:
> Kishon,
> 
> On Tuesday 06 February 2018 06:28 PM, Kishon Vijay Abraham I wrote:
>> Add UHS/HS200/DDR speed mode capability to MMC1 and MMC2 dt nodes.
>>
>> Signed-off-by: Kishon Vijay Abraham I <kishon@...com>
> 
> Along with this, dont we need to have
> 
> 	/delete-property/ mmc-hs200-1_8v;
> 
> for eMMC on Beagle x15 which does not support HS200?
> 
> Or are you planning to depend on lack of pinctrl entries for HS200 to
> take care of that?

right now it relies on lack of pinctrl entries but I think adding delete
property is appropriate. Actually I missed porting the patch that adds
/delete-property/.

Thanks
Kishon

> 
> Thanks,
> Sekhar
> 
> 
>> ---
>>  arch/arm/boot/dts/dra7.dtsi | 10 ++++++++++
>>  1 file changed, 10 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi
>> index 7bf33d522b14..feb496e7c5ef 100644
>> --- a/arch/arm/boot/dts/dra7.dtsi
>> +++ b/arch/arm/boot/dts/dra7.dtsi
>> @@ -1073,7 +1073,13 @@
>>  			status = "disabled";
>>  			pbias-supply = <&pbias_mmc_reg>;
>>  			max-frequency = <192000000>;
>> +			sd-uhs-sdr104;
>> +			sd-uhs-sdr50;
>> +			sd-uhs-ddr50;
>> +			sd-uhs-sdr25;
>> +			sd-uhs-sdr12;
>>  			cap-sd-highspeed;
>> +			mmc-ddr-1_8v;
>>  			cap-mmc-highspeed;
>>  		};
>>  
>> @@ -1092,6 +1098,10 @@
>>  			status = "disabled";
>>  			max-frequency = <192000000>;
>>  			cap-sd-highspeed;
>> +			sd-uhs-sdr25;
>> +			sd-uhs-sdr12;
>> +			mmc-hs200-1_8v;
>> +			mmc-ddr-1_8v;
>>  			cap-mmc-highspeed;
>>  		};
>>  
>> -- 
>> 2.11.0
>>
>