linux-kernel - Re: [PATCH] Update rf_type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180207110926.dzokcw2dwlinh2io@mwanda>
Date:   Wed, 7 Feb 2018 14:09:26 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     l4stpr0gr4m@...il.com
Cc:     gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
        arnd@...db.de, linux-kernel@...r.kernel.org, justin@...eeland.com,
        davem@...emloft.net, hdegoede@...hat.com,
        himanshujha199640@...il.com, hadess@...ess.net, joe@...ches.com,
        colin.king@...onical.com, Larry.Finger@...inger.net
Subject: Re: [PATCH] Update rf_type_definition

This is better.  But the subject should say [PATCH v2] and we need a
driver prefix.

On Wed, Feb 07, 2018 at 06:23:34AM +0900, l4stpr0gr4m@...il.com wrote:
> From: Kangmin Park <l4stpr0gr4m@...il.com>
> 
> enum RT_RF_TYPE_DEFINITION on rtl8723bs/include/rtw_rf.h
> is different from enum tag_HAL_RF_Type_Definition on
> rtl8723bs/include/HalVerDef.h
> 
> So, update them to be the same reference from
> enum rf_type on rtlwifi/wifi.h which recent version.
> 
> As a result, ODM_RF_TYPE_E needs to be updated as well
> Therefore, it is updated reference from enum odm_rf_type
> on rtlwifi/phydm/phydm_pre_define.h too.
> And update some additional code to check more
> chip versions that resulted from it.
> 
> Also, fixed some space required errors and
> line over 80 characters warnings by checkpatch.pl.

Don't do this.  It's considered unrelated white space change and it
makes the code hard to review.

To be honest, I don't know the code well enough to say if this patch is
a good idea generally...  It seems risky and I wish someone would test
it or a maintainer would Ack it.

regards,
dan carpenter