linux-kernel - Re: [PATCH v5 03/16] media: rkisp1: Add user space ABI definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d29bc615-2359-86c6-db5a-27cc111bc275@arm.com>
Date:   Wed, 7 Feb 2018 12:38:50 +0000
From:   Robin Murphy <robin.murphy@....com>
To:     Hans Verkuil <hverkuil@...all.nl>,
        Shunqian Zheng <zhengsq@...k-chips.com>,
        linux-rockchip@...ts.infradead.org, linux-media@...r.kernel.org
Cc:     Jose.Abreu@...opsys.com, devicetree@...r.kernel.org,
        eddie.cai.linux@...il.com, Joao.Pinto@...opsys.com,
        heiko@...ech.de, jacob2.chen@...k-chips.com,
        jeffy.chen@...k-chips.com, zyc@...k-chips.com,
        linux-kernel@...r.kernel.org, tfiga@...omium.org,
        Luis.Oliveira@...opsys.com, robh+dt@...nel.org,
        hans.verkuil@...co.com, laurent.pinchart@...asonboard.com,
        sakari.ailus@...ux.intel.com, allon.huang@...k-chips.com,
        mchehab@...nel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v5 03/16] media: rkisp1: Add user space ABI definitions

On 06/02/18 13:14, Hans Verkuil wrote:
[...]
> The one thing that I worry about is if these structs are the same for
> 32 and 64 bit arm.

I see some enums and bools in there - in general the storage size of 
those isn't even guaranteed to be consistent between different compiler 
implementations on the same platform, let alone across multiple 
platforms (especially WRT things like GCC's -fshort-enums).

In practice, under the standard ABIs for 32-bit and 64-bit Arm[1], I'd 
expect basic types other than longs and pointers to be pretty much the 
same; it's the imp-def C stuff I'd be a lot less confident about.

Robin.

[1]:http://infocenter.arm.com/help/topic/com.arm.doc.subset.swdev.abi/index.html