linux-kernel - Re: [PATCH] gpio: davinci: add support for pinmux gpio ranges

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdaTcCo93xqDNy7ixvF=aeF1VbML+OaJY8rtcEJZswXFbA@mail.gmail.com>
Date:   Wed, 7 Feb 2018 14:00:43 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     David Lechner <david@...hnology.com>
Cc:     linux-gpio@...r.kernel.org,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Keerthy <j-keerthy@...com>
Subject: Re: [PATCH] gpio: davinci: add support for pinmux gpio ranges

On Mon, Jan 22, 2018 at 12:09 AM, David Lechner <david@...hnology.com> wrote:

> This adds support for the pinmux gpio ranges feature to the DaVinci gpio
> driver. Only device tree is supported since the non-DT boards don't
> use a generic pinmux controller.
>
> Cc: Keerthy <j-keerthy@...com>
> Cc: Linus Walleij <linus.walleij@...aro.org>
> Signed-off-by: David Lechner <david@...hnology.com>

Nice, patch applied!

> +       if (of_property_read_bool(dev->of_node, "gpio-ranges")) {
> +               chips->chip.request = gpiochip_generic_request;
> +               chips->chip.free = gpiochip_generic_free;
> +       }

If the backing pin controller can do things like debounce
or open drain pin control, consider using also the
gpiochip_generic_config() callback in the future.

Yours,
Linus Walleij