linux-kernel - Re: [PATCH] platform/x86: dell-laptop: Add 2-in-1 devices to the DMI whitelist

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 7 Feb 2018 16:47:36 +0300
From:   Alexander Abrosimov <alexander.n.abrosimov@...il.com>
To:     Darren Hart <dvhart@...radead.org>
Cc:     Pali Rohár <pali.rohar@...il.com>,
        Mario.Limonciello@...l.com, Matthew Garrett <mjg59@...f.ucam.org>,
        Andy Shevchenko <andy@...radead.org>,
        platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] platform/x86: dell-laptop: Add 2-in-1 devices to the DMI whitelist

Darren, I have checked change on git.kernel.org and it seems to be merged twice:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/platform/x86/dell-laptop.c?id=fe486138788ba435ffa918c8d7aba05a77b6289a

How it can be fixed?

2018-01-26 17:42 GMT+03:00 <Mario.Limonciello@...l.com>:
>
> > -----Original Message-----
> > From: Pali Rohár [mailto:pali.rohar@...il.com]
> > Sent: Thursday, January 25, 2018 5:06 PM
> > To: Darren Hart <dvhart@...radead.org>
> > Cc: Alexander Abrosimov <alexander.n.abrosimov@...il.com>; Matthew Garrett
> > <mjg59@...f.ucam.org>; Limonciello, Mario <Mario_Limonciello@...l.com>; Andy
> > Shevchenko <andy@...radead.org>; platform-driver-x86@...r.kernel.org; linux-
> > kernel@...r.kernel.org
> > Subject: Re: [PATCH] platform/x86: dell-laptop: Add 2-in-1 devices to the DMI
> > whitelist
> >
> > On Thursday 25 January 2018 15:02:39 Darren Hart wrote:
> > > On Fri, Jan 26, 2018 at 01:48:57AM +0300, Alexander Abrosimov wrote:
> > > > SMBIOS 3.0.0 Specification introduced new Chassis Types field values for
> > > > 2-in-1 devices like tablets, convertibles and detachables. Dell's
> > > > Inspiron 2-in-1 and XPS 2-in-1 fall into this category and they have to
> > > > be added to the DMI whitelist, so rfkill and backlight can be controlled
> > > > for them as for other laptops.
> > > >
> > > > Signed-off-by: Alexander Abrosimov <alexander.n.abrosimov@...il.com>
> > >
> > > Thanks Alexander. Looks good - just going to give Pali and +Mario a chance to
> > > respond before merging...
> >
> > I have no comments for this. This should be confirmed by Mario or
> > somebody else from Dell, which DMI names are used for a new products.
>
> Yes these chassis types from SMBIOS 3.0 are covered by Dell specs and used for
> some products.
>
> This patch looks good to me.
>
> Reviewed-by: Mario Limonciello <mario.limonciello@...l.com>
> >
> > > > ---
> > > >  drivers/platform/x86/dell-laptop.c | 18 ++++++++++++++++++
> > > >  1 file changed, 18 insertions(+)
> > > >
> > > > diff --git a/drivers/platform/x86/dell-laptop.c b/drivers/platform/x86/dell-
> > laptop.c
> > > > index cd4725e7e0b5..23fc94d70ea1 100644
> > > > --- a/drivers/platform/x86/dell-laptop.c
> > > > +++ b/drivers/platform/x86/dell-laptop.c
> > > > @@ -110,6 +110,24 @@ static const struct dmi_system_id dell_device_table[]
> > __initconst = {
> > > >           },
> > > >   },
> > > >   {
> > > > +         .matches = {
> > > > +                 DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> > > > +                 DMI_MATCH(DMI_CHASSIS_TYPE, "30"), /*Tablet*/
> > > > +         },
> > > > + },
> > > > + {
> > > > +         .matches = {
> > > > +                 DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> > > > +                 DMI_MATCH(DMI_CHASSIS_TYPE, "31"), /*Convertible*/
> > > > +         },
> > > > + },
> > > > + {
> > > > +         .matches = {
> > > > +                 DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> > > > +                 DMI_MATCH(DMI_CHASSIS_TYPE, "32"), /*Detachable*/
> > > > +         },
> > > > + },
> > > > + {
> > > >           .ident = "Dell Computer Corporation",
> > > >           .matches = {
> > > >                   DMI_MATCH(DMI_SYS_VENDOR, "Dell Computer
> > Corporation"),
> > > > --
> > > > 2.13.6
> > > >
> > > >
> > >
> >
> > --
> > Pali Rohár
> > pali.rohar@...il.com




-- 
Best Regards,
Abrosimov Alexander, mailto:alexander.n.abrosimov@...il.com