linux-kernel - Re: [PATCH 1/2] staging: android: ion: Cleanup ion_page_pool_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 7 Feb 2018 20:05:03 +0530
From:   Sumit Semwal <sumit.semwal@...aro.org>
To:     Yisheng Xie <xieyisheng1@...wei.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Laura Abbott <labbott@...hat.com>, devel@...verdev.osuosl.org,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] staging: android: ion: Cleanup ion_page_pool_alloc_pages

Hi Yisheng,

On 7 February 2018 at 09:29, Yisheng Xie <xieyisheng1@...wei.com> wrote:
> ion_page_pool_alloc_pages calls alloc_pages to allocate pages for page
> pools. If alloc_pages return NULL, it will return NULL, or it will
> return the pages allocate from alloc_pages. So we can just return
> alloc_pages without any judgement.
>
With patch history comment addressed (same as the other patch you sent),
> Signed-off-by: Yisheng Xie <xieyisheng1@...wei.com>
Please feel free to add my
Acked-by: Sumit Semwal <sumit.semwal@...aro.org>

> ---
>  drivers/staging/android/ion/ion_page_pool.c | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/android/ion/ion_page_pool.c b/drivers/staging/android/ion/ion_page_pool.c
> index e3a6e32..6d2caf0 100644
> --- a/drivers/staging/android/ion/ion_page_pool.c
> +++ b/drivers/staging/android/ion/ion_page_pool.c
> @@ -11,13 +11,9 @@
>
>  #include "ion.h"
>
> -static void *ion_page_pool_alloc_pages(struct ion_page_pool *pool)
> +static inline struct page *ion_page_pool_alloc_pages(struct ion_page_pool *pool)
>  {
> -       struct page *page = alloc_pages(pool->gfp_mask, pool->order);
> -
> -       if (!page)
> -               return NULL;
> -       return page;
> +       return alloc_pages(pool->gfp_mask, pool->order);
>  }
>
>  static void ion_page_pool_free_pages(struct ion_page_pool *pool,
> --
> 1.7.12.4
>
Best,
Sumit.