linux-kernel - Re: [PATCH] x86/nospec: Fixup array_index_nospec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 6 Feb 2018 17:50:21 -0800
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Dan Williams <dan.j.williams@...el.com>
Cc:     Ingo Molnar <mingo@...nel.org>,
        "the arch/x86 maintainers" <x86@...nel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Andy Lutomirski <luto@...nel.org>,
        "H. Peter Anvin" <hpa@...or.com>,
        Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH] x86/nospec: Fixup array_index_nospec_mask() asm constraint

On Tue, Feb 6, 2018 at 5:33 PM, Dan Williams <dan.j.williams@...el.com> wrote:
> Allow the compiler to handle @size as an immediate value rather than
> allocating a register.

Actually, maybe that "ir" should be "g".

Because it's fine if it's a memory location too. "cmp" takes pretty
much anything, as long as the thing we compare _to_ is a register.

              Linus