linux-kernel - Re: [PATCH v2 4/4] dt-bindings: pwm-backlight: move brightness-levels to optional.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180207161057.fkgrspfkdtnp5ymk@oak.lan>
Date:   Wed, 7 Feb 2018 16:10:57 +0000
From:   Daniel Thompson <daniel.thompson@...aro.org>
To:     Enric Balletbo i Serra <enric.balletbo@...labora.com>
Cc:     Doug Anderson <dianders@...gle.com>, Pavel Machek <pavel@....cz>,
        Rob Herring <robh+dt@...nel.org>,
        Jingoo Han <jingoohan1@...il.com>,
        Richard Purdie <rpurdie@...ys.net>,
        Jacek Anaszewski <jacek.anaszewski@...il.com>,
        Brian Norris <briannorris@...gle.com>,
        Guenter Roeck <groeck@...gle.com>,
        Lee Jones <lee.jones@...aro.org>,
        Alexandru Stan <amstan@...gle.com>, linux-leds@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 4/4] dt-bindings: pwm-backlight: move
 brightness-levels to optional.

On Wed, Feb 07, 2018 at 03:13:37PM +0100, Enric Balletbo i Serra wrote:
> The patch 'backlight: pwm_bl: compute brightness of LED linearly to
> human eye' introduced a default brightness-levels table that is used
> when brightness-levels is not available in the dts. So move
> brightness-levels and default-brightness-level to be optional.
> 
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@...labora.com>
> Reviewed-by: Rob Herring <robh@...nel.org>

Acked-by: Daniel Thompson <daniel.thompson@...aro.org>

> ---
> Changes since v1:
> - Fix a couple of typos as requested by Rob.
>   - s/availablel/available/
>   - s/move move/move/
>   - "so move..." should be a new sentence.
> - Add Reviewed-by: Rob Herring <robh@...nel.org>
>  
>  .../devicetree/bindings/leds/backlight/pwm-backlight.txt  | 15 ++++++++-------
>  1 file changed, 8 insertions(+), 7 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/leds/backlight/pwm-backlight.txt b/Documentation/devicetree/bindings/leds/backlight/pwm-backlight.txt
> index ce9b5746b774..64fa2fbd98c9 100644
> --- a/Documentation/devicetree/bindings/leds/backlight/pwm-backlight.txt
> +++ b/Documentation/devicetree/bindings/leds/backlight/pwm-backlight.txt
> @@ -3,13 +3,6 @@ pwm-backlight bindings
>  Required properties:
>    - compatible: "pwm-backlight"
>    - pwms: OF device-tree PWM specification (see PWM binding[0])
> -  - brightness-levels: Array of distinct brightness levels. Typically these
> -      are in the range from 0 to 255, but any range starting at 0 will do.
> -      The actual brightness level (PWM duty cycle) will be interpolated
> -      from these values. 0 means a 0% duty cycle (darkest/off), while the
> -      last value in the array represents a 100% duty cycle (brightest).
> -  - default-brightness-level: the default brightness level (index into the
> -      array defined by the "brightness-levels" property)
>    - power-supply: regulator for supply voltage
>  
>  Optional properties:
> @@ -21,6 +14,14 @@ Optional properties:
>                            and enabling the backlight using GPIO.
>    - pwm-off-delay-ms: Delay in ms between disabling the backlight using GPIO
>                        and setting PWM value to 0.
> +  - brightness-levels: Array of distinct brightness levels. Typically these
> +                       are in the range from 0 to 255, but any range starting at
> +                       0 will do. The actual brightness level (PWM duty cycle)
> +                       will be interpolated from these values. 0 means a 0% duty
> +                       cycle (darkest/off), while the last value in the array
> +                       represents a 100% duty cycle (brightest).
> +  - default-brightness-level: The default brightness level (index into the
> +                              array defined by the "brightness-levels" property).
>    - num-interpolated-steps: Number of interpolated steps between each value
>                              of brightness-levels table. This way a high
>                              resolution pwm duty cycle can be used without
> -- 
> 2.15.1
>