linux-kernel - Re: [PATCH] drm/amd/powerplay: Remove extra pair of parentheses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 7 Feb 2018 11:19:10 -0800
From:   Guenter Roeck <groeck@...gle.com>
To:     Matthias Kaehlcke <mka@...omium.org>
Cc:     Alex Deucher <alexander.deucher@....com>,
        Christian König <christian.koenig@....com>,
        David Zhou <David1.Zhou@....com>,
        David Airlie <airlied@...ux.ie>, Rex Zhu <Rex.Zhu@....com>,
        amd-gfx list <amd-gfx@...ts.freedesktop.org>,
        Maling list - DRI developers 
        <dri-devel@...ts.freedesktop.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Guenter Roeck <groeck@...omium.org>,
        Justin TerAvest <teravest@...omium.org>,
        Craig Bergstrom <craigb@...omium.org>
Subject: Re: [PATCH] drm/amd/powerplay: Remove extra pair of parentheses

On Wed, Feb 7, 2018 at 11:10 AM, Matthias Kaehlcke <mka@...omium.org> wrote:
> The double parentheses are not needed. Removing them fixes the following
> warning when building with clang:
>
> drivers/gpu/drm/amd/powerplay/smumgr/tonga_smumgr.c:419:29:
>   error: equality comparison with extraneous parentheses
>     [-Werror,-Wparentheses-equality]
>   if ((data->vdd_gfx_control == SMU7_VOLTAGE_CONTROL_BY_SVID2)) {
>
> Signed-off-by: Matthias Kaehlcke <mka@...omium.org>

Reviewed-by: Guenter Roeck <groeck@...omium.org>

> ---
>  drivers/gpu/drm/amd/powerplay/smumgr/tonga_smumgr.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/tonga_smumgr.c b/drivers/gpu/drm/amd/powerplay/smumgr/tonga_smumgr.c
> index 79e5c05571bc..f5b3de29b632 100644
> --- a/drivers/gpu/drm/amd/powerplay/smumgr/tonga_smumgr.c
> +++ b/drivers/gpu/drm/amd/powerplay/smumgr/tonga_smumgr.c
> @@ -416,7 +416,7 @@ static int tonga_populate_cac_tables(struct pp_hwmgr *hwmgr,
>                         convert_to_vid(vddc_lookup_table->entries[index].us_cac_high);
>         }
>
> -       if ((data->vdd_gfx_control == SMU7_VOLTAGE_CONTROL_BY_SVID2)) {
> +       if (data->vdd_gfx_control == SMU7_VOLTAGE_CONTROL_BY_SVID2) {
>                 /* We are populating vddgfx CAC data to BapmVddgfx table in split mode */
>                 for (count = 0; count < vddgfx_level_count; count++) {
>                         index = phm_get_voltage_index(vddgfx_lookup_table,
> --
> 2.16.0.rc1.238.g530d649a79-goog
>