linux-kernel - Re: [PATCH] tile/pci_gx: Make setup_pcie_rc_delay _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <mhng-c0eb9b65-5e20-4217-be8d-cd26b79a2724@palmer-si-x1c4>
Date:   Wed, 07 Feb 2018 17:00:31 -0800 (PST)
From:   Palmer Dabbelt <palmer@...belt.com>
To:     douly.fnst@...fujitsu.com
CC:     linux-kernel@...r.kernel.org, douly.fnst@...fujitsu.com,
        bhelgaas@...gle.com, cmetcalf@...lanox.com,
        akpm@...ux-foundation.org
Subject:     Re: [PATCH] tile/pci_gx: Make setup_pcie_rc_delay __init

On Tue, 16 Jan 2018 19:45:05 PST (-0800), douly.fnst@...fujitsu.com wrote:
> The early_param() is only called during kernel initialization, So Linux
> marks the functions of it with __init macro to save memory.
>
> But it forgot to mark setup_pcie_rc_delay(). So, Make it __init as well.
>
> Cc: Bjorn Helgaas <bhelgaas@...gle.com>
> Cc: Palmer Dabbelt <palmer@...belt.com>
> Cc: Chris Metcalf<cmetcalf@...lanox.com>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Signed-off-by: Dou Liyang <douly.fnst@...fujitsu.com>
> ---
>  arch/tile/kernel/pci_gx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/tile/kernel/pci_gx.c b/arch/tile/kernel/pci_gx.c
> index 9aa238ac7b35..9a874e98b1cc 100644
> --- a/arch/tile/kernel/pci_gx.c
> +++ b/arch/tile/kernel/pci_gx.c
> @@ -617,7 +617,7 @@ static void fixup_read_and_payload_sizes(struct pci_controller *controller)
>  	}
>  }
>
> -static int setup_pcie_rc_delay(char *str)
> +static int __init setup_pcie_rc_delay(char *str)
>  {
>  	unsigned long delay = 0;
>  	unsigned long trio_index;

Sorry this sat in my inbox for a while.  I talked to Chris and he's not 
maintaining Linux any more.  I maintain the RISC-V port, so I'm not actually 
sure how this got to me, but I don't mind collecting Tilera patches and 
submitting them to Linus.  Note that I don't have any TileGx hardware or even a 
compiler, so it'd be a very low bar for maintenance.

If that's OK with everyone there then I can submit something that's more of a 
direct question to the mailing list.