[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20180208135423.GC10234@krava>
Date: Thu, 8 Feb 2018 14:54:23 +0100
From: Jiri Olsa <jolsa@...hat.com>
To: John Garry <john.garry@...wei.com>
Cc: peterz@...radead.org, mingo@...hat.com, acme@...nel.org,
alexander.shishkin@...ux.intel.com, namhyung@...nel.org,
ak@...ux.intel.com, wcohen@...hat.com, will.deacon@....com,
ganapatrao.kulkarni@...ium.com, linux-kernel@...r.kernel.org,
linuxarm@...wei.com, zhangshaokun@...ilicon.com,
linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 5/9] perf utils: add support for arch standard events
On Wed, Feb 07, 2018 at 01:45:00AM +0800, John Garry wrote:
SNIP
> static void print_events_table_suffix(FILE *outfp)
> {
> fprintf(outfp, "{\n");
> @@ -407,6 +469,52 @@ static char *real_event(const char *name, char *event)
> return event;
> }
>
> +static void fixup_field(char *from, char **to)
> +{
> + *to = malloc(strlen(from));
> +
> + strcpy(*to, from);
> +}
could you just call '*to = strdup(from)' in here?
jirka
Powered by blists - more mailing lists