linux-kernel - Re: [PATCH 2/9] perf utils: add support for pmu events vendor sub-directory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180208135554.GL10234@krava>
Date:   Thu, 8 Feb 2018 14:55:54 +0100
From:   Jiri Olsa <jolsa@...hat.com>
To:     John Garry <john.garry@...wei.com>
Cc:     peterz@...radead.org, mingo@...hat.com, acme@...nel.org,
        alexander.shishkin@...ux.intel.com, namhyung@...nel.org,
        ak@...ux.intel.com, wcohen@...hat.com, will.deacon@....com,
        ganapatrao.kulkarni@...ium.com, linux-kernel@...r.kernel.org,
        linuxarm@...wei.com, zhangshaokun@...ilicon.com,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 2/9] perf utils: add support for pmu events vendor
 sub-directory

On Wed, Feb 07, 2018 at 01:44:57AM +0800, John Garry wrote:
> For some architectures (like arm), it is required to support
> a vendor sub-directory and not locate all the JSONs for a
> specific vendor in the same folder.
> 
> This is because all the events for the same vendor will be
> placed in the same pmu events table, which may cause conflict.
> This conflict would be in the instance that a vendor's custom
> implemented events do have the same meaning on different platforms,
> so events in the pmu table would conflict. In addition, per list
> command may show events which are not even supported for a given
> platform.
> 
> This patch adds support for a arch/vendor/platform directory
> hierarchy, while maintaining backwards-compatibility for existing
> arch/platform structure. In this, each platform would always have
> its own pmu events table.
> 
> In generated file pmu_events.c, each platform table name is in
> the format pme{_vendor}_platform, like this:
> 
> struct pmu_events_map pmu_events_map[] = {
> {
> 	.cpuid = "0x00000000420f5160",
> 	.version = "v1",
> 	.type = "core",
> 	.table = pme_cavium_thunderx2
> },
> {
> 	.cpuid = 0,
> 	.version = 0,
> 	.type = 0,
> 	.table = 0,
> },
> };
> 
> Signed-off-by: John Garry <john.garry@...wei.com>

Acked-by: Jiri Olsa <jolsa@...nel.org>

thanks,
jirka