linux-kernel - Re: [PATCH] ACPI/IORT: Remove linker section for IORT entries again

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180208135856.GA4360@e107981-ln.cambridge.arm.com>
Date:   Thu, 8 Feb 2018 13:58:56 +0000
From:   Lorenzo Pieralisi <lorenzo.pieralisi@....com>
To:     Jia He <hejianet@...il.com>
Cc:     linux-arch@...r.kernel.org, linux-kernel@...r.kernel.org,
        Arnd Bergmann <arnd@...db.de>,
        Daniel Lezcano <daniel.lezcano@...aro.org>
Subject: Re: [PATCH] ACPI/IORT: Remove linker section for IORT entries again

On Thu, Feb 08, 2018 at 10:37:54AM +0800, Jia He wrote:
> 
> 
> On 2/7/2018 7:41 PM, Lorenzo Pieralisi Wrote:
> >On Tue, Feb 06, 2018 at 08:11:34PM -0800, Jia He wrote:
> >>In commit 316ca8804ea8 ("ACPI/IORT: Remove linker section for IORT entries
> >>probing"), iort entries was removed in vmlinux.lds.h. But in
> >>commit 2fcc112af37f ("clocksource/drivers: Rename clksrc table to timer"),
> >>this line was back incorrectly.
> >>
> >>It does no harm except for adding some useless symbols, so fix it.
> >>
> >>Signed-off-by: Jia He <hejianet@...il.com>
> forget to add another Signed-off-by line(because of my company's opensource
> rules)
> 
> Signed-off-by: Jia He <jia.he@...-semitech.com>
> 
> >>---
> >>  include/asm-generic/vmlinux.lds.h | 1 -
> >>  1 file changed, 1 deletion(-)
> >Acked-by: Lorenzo Pieralisi <lorenzo.pieralisi@....com>
> >
> >Who is picking this up ?
> Sorry, do you mean who is picking up acpi/iort subsystem?

No, I meant who (as-in me or Daniel) will merge this patch.

I will take it.

Lorenzo

> I can't answer this question. I find this minor bug while doing the code
> review.
> 
> Cheers,
> Jia
> >>diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h
> >>index 1ab0e52..58b1dab 100644
> >>--- a/include/asm-generic/vmlinux.lds.h
> >>+++ b/include/asm-generic/vmlinux.lds.h
> >>@@ -589,7 +589,6 @@
> >>  	IRQCHIP_OF_MATCH_TABLE()					\
> >>  	ACPI_PROBE_TABLE(irqchip)					\
> >>  	ACPI_PROBE_TABLE(timer)						\
> >>-	ACPI_PROBE_TABLE(iort)						\
> >>  	EARLYCON_TABLE()
> >>  #define INIT_TEXT							\
> >>-- 
> >>2.7.4
> >>