linux-kernel - Re: [PATCH] cramfs: better MTD dependency expression

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <518cf447-3eca-3030-df45-7ed5da2e2521@infradead.org>
Date:   Thu, 8 Feb 2018 12:01:46 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Linus Torvalds <torvalds@...ux-foundation.org>,
        Nicolas Pitre <nicolas.pitre@...aro.org>
Cc:     Al Viro <viro@...iv.linux.org.uk>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH] cramfs: better MTD dependency expression

On 02/08/2018 11:38 AM, Linus Torvalds wrote:
> On Wed, Feb 7, 2018 at 7:08 PM, Nicolas Pitre <nicolas.pitre@...aro.org> wrote:
>>
>> Viro once told me that my cramfs pull requests could go either to him or
>> to you. I have only this one patch at the moment, and since it depends
>> on a commit that recently appeared in your tree I'm therefore sending it
>> directly to you.
> 
> Applied.
> 
> Although I'm not entirely convinced that the simpler dependency is
> easier to _read_ and understand.
> 
> It is clearly simpler, though.
> 
>             Linus
> 


There was some pushback on the patch, mostly from Arnd.

I think we agree that it's not easier to read/understand, but Nicolas
is the maintainer... and he patched kconfig so that this would work.
kconfig did need fixing in that respect -- it was supposed to work
but didn't.

(That was commit 9059a3493efea6492451430c7e2fa0af799a2abb:
kconfig: fix relational operators for bool and tristate symbols)

-- 
~Randy