linux-kernel - Re: [PATCH 07/20] riscv: Remove ARCH_WANT_OPTIONAL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180208225606.slie77gk7nnmzh6y@huvuddator>
Date:   Thu, 8 Feb 2018 23:56:07 +0100
From:   Ulf Magnusson <ulfalizer@...il.com>
To:     Palmer Dabbelt <palmer@...ive.com>
Cc:     linux-kernel@...r.kernel.org, linux-kbuild@...r.kernel.org,
        tfiga@...omium.org, paul.burton@...s.com, m.szyprowski@...sung.com,
        egtvedt@...fundet.no, linus.walleij@...aro.org,
        vgupta@...opsys.com, mgorman@...hsingularity.net,
        Christoph Hellwig <hch@....de>, mina86@...a86.com,
        robh@...nel.org, sboyd@...eaurora.org, paulus@...abs.org,
        Will Deacon <will.deacon@....com>, tony@...mide.com,
        npiggin@...il.com, yamada.masahiro@...ionext.com,
        albert@...ive.com, linux-riscv@...ts.infradead.org
Subject: Re: [PATCH 07/20] riscv: Remove ARCH_WANT_OPTIONAL_GPIOLIB select

On Thu, Feb 08, 2018 at 10:34:19AM -0800, Palmer Dabbelt wrote:
> On Sun, 04 Feb 2018 17:21:19 PST (-0800), ulfalizer@...il.com wrote:
> > The ARCH_WANT_OPTIONAL_GPIOLIB symbol was removed in commit 65053e1a7743
> > ("gpio: delete ARCH_[WANTS_OPTIONAL|REQUIRE]_GPIOLIB"). GPIOLIB should
> > just be selected explicitly if needed.
> > 
> > Remove the ARCH_WANT_OPTIONAL_GPIOLIB select from RISCV.
> > 
> > See commit 0145071b3314 ("x86: Do away with
> > ARCH_[WANT_OPTIONAL|REQUIRE]_GPIOLIB") and commit da9a1c6767 ("arm64: do
> > away with ARCH_[WANT_OPTIONAL|REQUIRE]_GPIOLIB") as well.
> > 
> > Discovered with the
> > https://github.com/ulfalizer/Kconfiglib/blob/master/examples/list_undefined.py
> > script.
> > 
> > Signed-off-by: Ulf Magnusson <ulfalizer@...il.com>
> > ---
> >  arch/riscv/Kconfig | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig
> > index ff69c77b9e78..716e90e60e5c 100644
> > --- a/arch/riscv/Kconfig
> > +++ b/arch/riscv/Kconfig
> > @@ -19,7 +19,6 @@ config RISCV
> >  	select GENERIC_STRNLEN_USER
> >  	select GENERIC_SMP_IDLE_THREAD
> >  	select GENERIC_ATOMIC64 if !64BIT || !RISCV_ISA_A
> > -	select ARCH_WANT_OPTIONAL_GPIOLIB
> >  	select HAVE_MEMBLOCK
> >  	select HAVE_MEMBLOCK_NODE_MAP
> >  	select HAVE_DMA_API_DEBUG
> 
> Thanks!
> 
> (If you want these through my tree, just say something.)

I didn't have a particular tree in mind for these patches, so feel free
to take it.

> 
> Reviewed-by: Palmer Dabbelt <palmer@...ive.com>

Cheers,
Ulf