linux-kernel - Re: [PATCH] mm/migrate: Rename various page allocation helper functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <5458c2c9-3534-c00d-7abf-3315debbf896@linux.vnet.ibm.com>
Date:   Thu, 8 Feb 2018 09:37:12 +0530
From:   Anshuman Khandual <khandual@...ux.vnet.ibm.com>
To:     Anshuman Khandual <khandual@...ux.vnet.ibm.com>,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org
Cc:     akpm@...ux-foundation.org, mhocko@...e.com, hughd@...gle.com
Subject: Re: [PATCH] mm/migrate: Rename various page allocation helper
 functions

On 02/04/2018 12:28 PM, Anshuman Khandual wrote:
> Allocation helper functions for migrate_pages() remmain scattered with
> similar names making them really confusing. Rename these functions based
> on type of the intended migration. Function alloc_misplaced_dst_page()
> remains unchanged as its highly specialized. The renamed functions are
> listed below. Functionality of migration remains unchanged.
> 
> 1. alloc_migrate_target -> new_page_alloc
> 2. new_node_page -> new_page_alloc_othernode
> 3. new_page -> new_page_alloc_keepnode
> 4. alloc_new_node_page -> new_page_alloc_node
> 5. new_page -> new_page_alloc_mempolicy

Hello Michal/Hugh,

Does the renaming good enough or we should just not rename these.