linux-kernel - Re: scripts/coccinelle/misc/shift.cocci: Refactoring?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a241776d-85bf-cbf1-067b-fbd0b80c0e5e@users.sourceforge.net>
Date:   Fri, 9 Feb 2018 15:10:20 +0100
From:   SF Markus Elfring <elfring@...rs.sourceforge.net>
To:     cocci@...teme.lip6.fr, Julia Lawall <julia.lawall@...6.fr>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org,
        Dan Carpenter <dan.carpenter@...cle.com>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Wolfram Sang <wsa+renesas@...g-engineering.com>
Subject: Re: scripts/coccinelle/misc/shift.cocci: Refactoring?

> +|
> +WARN_ON(x op@p y)
> +|
> +WARN_ON_ONCE(x op@p y)
> +|

Can it be nice to work with nested SmPL disjunctions so that a bit of
duplicate SmPL code will be reduced?


> +coccilib.org.print_todo(j0[0], msg)

Will it be nicer to pass a string literal instead of a variable for the message
as a method parameter?

Regards,
Markus