linux-kernel - Re: [PATCH] ALSA: usb-audio: add implicit fb quirk for Behringer UFX1204

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <95a0b1fe-24e3-e902-8452-0b28c2c95315@gmail.com>
Date:   Fri, 9 Feb 2018 16:51:36 +0200
From:   Lassi Ylikojola <lassi.ylikojola@...il.com>
To:     Takashi Iwai <tiwai@...e.de>
Cc:     alsa-devel@...a-project.org, arvind.yadav.cs@...il.com,
        bhumirks@...il.com, perex@...ex.cz, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ALSA: usb-audio: add implicit fb quirk for Behringer
 UFX1204

Add quirk to ensure a sync endpoint is properly configured.
This patch is a fix for same symptoms on Behringer UFX1204 as patch
from Albertto Aquirre on Dec 8 2016 for Axe-Fx II.
Resending. Seems that there is a difference between git diff/commit versions 2.7.4 and 2.14.3.
I had to insert a line break with 2.4.13 to align properly(hopefully). 

Signed-off-by: Lassi Ylikojola <lassi.ylikojola@...il.com>
---
 sound/usb/pcm.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/sound/usb/pcm.c b/sound/usb/pcm.c
index b9c9a19f9588..116a6ccc5b31 100644
--- a/sound/usb/pcm.c
+++ b/sound/usb/pcm.c
@@ -357,6 +357,16 @@ static int set_sync_ep_implicit_fb_quirk(struct snd_usb_substream *subs,
 
                alts = &iface->altsetting[1];
                goto add_sync_ep;
+       case USB_ID(0x1397, 0x0002):
+               ep = 0x81;
+               iface = usb_ifnum_to_if(dev, 1);
+
+               if (!iface || iface->num_altsetting == 0)
+                       return -EINVAL;
+
+               alts = &iface->altsetting[1];
+               goto add_sync_ep;
+
 
        }
        if (attr == USB_ENDPOINT_SYNC_ASYNC &&
-- 
2.14.3