linux-kernel - Re: [PATCH v3 2/4] gpio: Add GPIO driver for Nintendo Wii

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180209151116.GQ21977@gate.crashing.org>
Date:   Fri, 9 Feb 2018 09:11:16 -0600
From:   Segher Boessenkool <segher@...nel.crashing.org>
To:     Jonathan Neuschäfer <j.neuschaefer@....net>
Cc:     linux-kernel@...r.kernel.org, Joel Stanley <joel@....id.au>,
        linuxppc-dev@...ts.ozlabs.org, linux-gpio@...r.kernel.org,
        devicetree@...r.kernel.org,
        Albert Herranz <albert_herranz@...oo.es>,
        Linus Walleij <linus.walleij@...aro.org>
Subject: Re: [PATCH v3 2/4] gpio: Add GPIO driver for Nintendo Wii

On Fri, Feb 09, 2018 at 01:07:29PM +0100, Jonathan Neuschäfer wrote:
> The Nintendo Wii's chipset (called "Hollywood") has a GPIO controller
> that supports a configurable number of pins (up to 32), interrupts, and
> some special mechanisms to share the controller between the system's
> security processor (an ARM926) and the PowerPC CPU. Pin multiplexing is
> not supported.
> 
> This patch adds a basic driver for this GPIO controller. Interrupt
> support will come in a later patch.
> 
> This patch is based on code developed by Albert Herranz and the GameCube
> Linux Team, file arch/powerpc/platforms/embedded6xx/hlwd-gpio.c,
> available at https://github.com/DeltaResero/GC-Wii-Linux-Kernels, but
> has grown quite dissimilar.
> 
> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@....net>
> Cc: Albert Herranz <albert_herranz@...oo.es>
> Cc: Segher Boessenkool <segher@...nel.crashing.org>

Reviewed-by: Segher Boessenkool <segher@...nel.crashing.org>

Looks just fine to me :-)


Segher