linux-kernel - Re: [PATCH] media: i2c: adv748x: Fix cleanup jump on chip identification

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180209153441.GD7666@bigcity.dyn.berto.se>
Date:   Fri, 9 Feb 2018 16:34:41 +0100
From:   Niklas Söderlund 
        <niklas.soderlund@...natech.se>
To:     Kieran Bingham <kbingham@...nel.org>
Cc:     Kieran Bingham <kieran.bingham@...asonboard.com>,
        linux-renesas-soc@...r.kernel.org, linux-media@...r.kernel.org,
        Kieran Bingham <kieran.bingham+renesas@...asonboard.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] media: i2c: adv748x: Fix cleanup jump on chip
 identification

Hi Kieran,

Thanks for your patch.

On 2018-02-07 21:11:35 +0000, Kieran Bingham wrote:
> From: Kieran Bingham <kieran.bingham+renesas@...asonboard.com>
> 
> The error handling for the adv748x_identify_chip() call erroneously
> jumps to the err_cleanup_clients label before the clients have been
> established.
> 
> Correct this by jumping to the next (and correct) label in the cleanup
> code: err_cleanup_dt.
> 
> Fixes: 3e89586a64df ("media: i2c: adv748x: add adv748x driver")
> 
> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@...asonboard.com>

Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@...natech.se>

> ---
>  drivers/media/i2c/adv748x/adv748x-core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/i2c/adv748x/adv748x-core.c b/drivers/media/i2c/adv748x/adv748x-core.c
> index 6d62b817ed00..6ccaad7e9eca 100644
> --- a/drivers/media/i2c/adv748x/adv748x-core.c
> +++ b/drivers/media/i2c/adv748x/adv748x-core.c
> @@ -651,7 +651,7 @@ static int adv748x_probe(struct i2c_client *client,
>  	ret = adv748x_identify_chip(state);
>  	if (ret) {
>  		adv_err(state, "Failed to identify chip");
> -		goto err_cleanup_clients;
> +		goto err_cleanup_dt;
>  	}
>  
>  	/* Configure remaining pages as I2C clients with regmap access */
> -- 
> 2.7.4
> 

-- 
Regards,
Niklas Söderlund