linux-kernel - Re: [PATCH] ftrace: fix the file mode of graph tracer and stacktracer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180208222122.5ba7c7fe@vmware.local.home>
Date:   Thu, 8 Feb 2018 22:21:22 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     "Zhengyuan Liu" <liuzhengyuan@...inos.cn>
Cc:     "mingo" <mingo@...hat.com>,
        "linux-kernel" <linux-kernel@...r.kernel.org>,
        "liuzhengyuang521" <liuzhengyuang521@...il.com>,
        "linx.z.chen" <linx.z.chen@...el.com>
Subject: Re: [PATCH] ftrace: fix the file mode of graph tracer and
 stacktracer

On Fri, 9 Feb 2018 10:33:31 +0800
"Zhengyuan Liu" <liuzhengyuan@...inos.cn> wrote:

> It doesn't affect root writing to those files as root is a super user and
> can access to any write-only files.  I just want to make those writable

Ah, I know when I vim a file that's read only, even for root vim will
complain. But there's no complaining with redirection.

I just tried vim on set_graph_function, and yeah, it does complain.

> file to look consistent with others, seeing bellow:
> 
> -rw-r--r--  1 root root  set_event_pid
> -rw-r--r--  1 root root  set_ftrace_filter
> -rw-r--r--  1 root root  set_ftrace_notrace
> -rw-r--r--  1 root root  set_ftrace_pid
> -r--r--r--  1 root root   set_graph_function
> -r--r--r--  1 root root  set_graph_notrace

Yeah, I understand.

> 
> If this patch makes no sense, just ignore it!

No no, it makes perfect sense. I plan on adding it. But it's not that
important to be included for stable. Expect to see this in 4.17.

Thanks!

-- Steve