linux-kernel - Re: [PATCH v3 0/4] fpga: don't use drvdata in common code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 9 Feb 2018 09:18:22 -0800
From:   Moritz Fischer <mdf@...nel.org>
To:     Alan Tull <atull@...nel.org>
Cc:     Moritz Fischer <mdf@...nel.org>,
        Anatolij Gustschin <agust@...x.de>,
        Matthew Gerlach <matthew.gerlach@...ux.intel.com>,
        Joel Holdsworth <joel@...webreathe.org.uk>,
        Florian Fainelli <f.fainelli@...il.com>,
        Joshua Clayton <stillcompiling@...il.com>,
        Dinh Nguyen <dinguyen@...nel.org>,
        linux-kernel@...r.kernel.org, linux-fpga@...r.kernel.org
Subject: Re: [PATCH v3 0/4] fpga: don't use drvdata in common code

On Wed, Feb 07, 2018 at 03:05:26PM -0600, Alan Tull wrote:
> Setting drvdata is fine for DT based devices which have one manager,
> bridge, or region device per platform device.  However, PCIe based
> devices may have multiple FPGA mgr/bridge/regions under one PCIe
> device.  Without these changes, PCIe-based solutions have to create an
> extra device for each child mgr/bridge/region to hold drvdata.
> 
> Also changing the fpga_*_register/unregister functions to take the
> corresponding struct as the only parameter wherever they weren't already.
> 
> * int fpga_bridge_register(struct fpga_bridge *br)
> * int fpga_mgr_register(struct fpga_manager *mgr)
> * int fpga_region_register(struct fpga_region *region)
> 
> * void fpga_bridge_unregister(struct fpga_bridge *br)
> * void fpga_mgr_unregister(struct fpga_manager *mgr)
> * int fpga_region_unregister(struct fpga_region *region)
> 
> Changes from v2:
> * Drop patch 5 which fixed a DT overlay issue.  The underlying
>   issue was fixed in the main DT overlay code.
> * Minor code cleanup to make it more obvious that the changes
>   were not breaking anything
> * Added Moritz' ack on patch 1
> 
> Alan Tull (4):
>   fpga: region: don't use drvdata in common fpga code
>   fpga: manager: don't use drvdata in common fpga code
>   fpga: bridge: don't use drvdata in common fpga code
>   fpga: region: change fpga_region_register to have one param

Acked-by: Moritz Fischer <mdf@...nel.org> for the ones I haven't ack'd
so far.

Thanks,

Moritz
> 
>  Documentation/fpga/fpga-mgr.txt     | 24 +++++++++++++++------
>  Documentation/fpga/fpga-region.txt  |  3 +--
>  drivers/fpga/altera-cvp.c           | 18 ++++++++++++----
>  drivers/fpga/altera-fpga2sdram.c    | 20 +++++++++++++----
>  drivers/fpga/altera-freeze-bridge.c | 18 +++++++++++++---
>  drivers/fpga/altera-hps2fpga.c      | 16 +++++++++++---
>  drivers/fpga/altera-pr-ip-core.c    | 17 +++++++++++++--
>  drivers/fpga/altera-ps-spi.c        | 18 +++++++++++++---
>  drivers/fpga/fpga-bridge.c          | 43 ++++++++++++++-----------------------
>  drivers/fpga/fpga-mgr.c             | 39 ++++++++++++---------------------
>  drivers/fpga/fpga-region.c          |  9 ++++++--
>  drivers/fpga/ice40-spi.c            | 20 +++++++++++++----
>  drivers/fpga/of-fpga-region.c       |  4 +++-
>  drivers/fpga/socfpga-a10.c          | 16 +++++++++++---
>  drivers/fpga/socfpga.c              | 18 +++++++++++++---
>  drivers/fpga/ts73xx-fpga.c          | 18 +++++++++++++---
>  drivers/fpga/xilinx-pr-decoupler.c  | 15 ++++++++++---
>  drivers/fpga/xilinx-spi.c           | 18 +++++++++++++---
>  drivers/fpga/zynq-fpga.c            | 16 +++++++++++---
>  include/linux/fpga/fpga-bridge.h    |  7 +++---
>  include/linux/fpga/fpga-mgr.h       |  8 +++----
>  include/linux/fpga/fpga-region.h    |  4 +++-
>  22 files changed, 256 insertions(+), 113 deletions(-)
> 
> -- 
> 2.7.4
>