[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <1518215316-21504-4-git-send-email-khoroshilov@ispras.ru>
Date: Sat, 10 Feb 2018 01:28:36 +0300
From: Alexey Khoroshilov <khoroshilov@...ras.ru>
To: Boris Brezillon <boris.brezillon@...e-electrons.com>
Cc: Alexey Khoroshilov <khoroshilov@...ras.ru>,
Stefan Agner <stefan@...er.ch>,
Richard Weinberger <richard@....at>,
linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org,
ldv-project@...uxtesting.org
Subject: [PATCH v4 3/3] mtd: nand: vf610: check mtd_device_register() return code
vf610_nfc_probe() misses error handling of mtd_device_register().
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Alexey Khoroshilov <khoroshilov@...ras.ru>
---
drivers/mtd/nand/vf610_nfc.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/mtd/nand/vf610_nfc.c b/drivers/mtd/nand/vf610_nfc.c
index 9cc5992e88c8..64fed3d9e3d4 100644
--- a/drivers/mtd/nand/vf610_nfc.c
+++ b/drivers/mtd/nand/vf610_nfc.c
@@ -782,8 +782,13 @@ static int vf610_nfc_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, mtd);
/* Register device in MTD */
- return mtd_device_register(mtd, NULL, 0);
+ err = mtd_device_register(mtd, NULL, 0);
+ if (err)
+ goto err_cleanup_nand;
+ return 0;
+err_cleanup_nand:
+ nand_cleanup(chip);
err_disable_clk:
clk_disable_unprepare(nfc->clk);
return err;
--
2.7.4
Powered by blists - more mailing lists