linux-kernel - Re: [PATCH 1/3] X86/nVMX: Properly set spec_ctrl and pred

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1518253624.3677.276.camel@infradead.org>
Date:   Sat, 10 Feb 2018 09:07:04 +0000
From:   David Woodhouse <dwmw2@...radead.org>
To:     Jim Mattson <jmattson@...gle.com>,
        KarimAllah Ahmed <karahmed@...zon.de>
Cc:     kvm list <kvm@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Paolo Bonzini <pbonzini@...hat.com>,
        Radim Krčmář <rkrcmar@...hat.com>
Subject: Re: [PATCH 1/3] X86/nVMX: Properly set spec_ctrl and pred_cmd
 before merging MSRs

On Fri, 2018-02-09 at 15:15 -0800, Jim Mattson wrote:
> On Thu, Feb 8, 2018 at 2:53 PM, KarimAllah Ahmed <karahmed@...zon.de> wrote:
> > 
> > These two variables should check whether SPEC_CTRL and PRED_CMD are
> > supposed to be passed through to L2 guests or not. While
> > msr_write_intercepted_l01 would return 'true' if it is not passed through.
> > 
> > So just invert the result of msr_write_intercepted_l01 to implement the
> > correct semantics.
> > 
> > Fixes: 086e7d4118cc ("KVM: VMX: Allow direct access to MSR_IA32_SPEC_CTRL")
> > Signed-off-by: KarimAllah Ahmed <karahmed@...zon.de>
> > Cc: Paolo Bonzini <pbonzini@...hat.com>
> > Cc: Radim Krčmář <rkrcmar@...hat.com>
> > Cc: kvm@...r.kernel.org
> > Cc: linux-kernel@...r.kernel.org
> Reviewed-by: Jim Mattson <jmattson@...gle.com>

We should take this (and 2/3 but not 3/3) through tip/x86/pti too,
right? 
Download attachment "smime.p7s" of type "application/x-pkcs7-signature" (5213 bytes)