linux-kernel - Re: [PATCH 3/6] sched/isolation: Isolate workqueues when "nohz

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180210102203.GA14047@lerouge>
Date:   Sat, 10 Feb 2018 11:22:05 +0100
From:   Frederic Weisbecker <frederic@...nel.org>
To:     Ingo Molnar <mingo@...nel.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Chris Metcalf <cmetcalf@...lanox.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Luiz Capitulino <lcapitulino@...hat.com>,
        Christoph Lameter <cl@...ux.com>,
        "Paul E . McKenney" <paulmck@...ux.vnet.ibm.com>,
        Wanpeng Li <kernellwp@...il.com>,
        Mike Galbraith <efault@....de>, Rik van Riel <riel@...hat.com>
Subject: Re: [PATCH 3/6] sched/isolation: Isolate workqueues when
 "nohz_full=" is set

On Fri, Feb 09, 2018 at 07:55:44AM +0100, Ingo Molnar wrote:
> 
> * Frederic Weisbecker <frederic@...nel.org> wrote:
> 
> > -	flags = HK_FLAG_TICK | HK_FLAG_TIMER | HK_FLAG_RCU | HK_FLAG_MISC;
> > +	flags = HK_FLAG_TICK | HK_FLAG_WQ | HK_FLAG_TIMER |
> > +		HK_FLAG_RCU | HK_FLAG_MISC;
> 
> > -	cpumask_copy(wq_unbound_cpumask, housekeeping_cpumask(HK_FLAG_DOMAIN));
> > +	cpumask_copy(wq_unbound_cpumask,
> > +		     housekeeping_cpumask(HK_FLAG_DOMAIN | HK_FLAG_WQ));
> 
> LGTM, but _please_ don't do these ugly line-breaks, just keep it slightly over 
> col80.

Works for me, I'll fix.

Thanks.