linux-kernel - Re: [PATCH] watchdog: coh901327: make license text and module licence match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <63b79477-3506-0cb7-3d5d-a2c34d2de82c@roeck-us.net>
Date:   Sat, 10 Feb 2018 07:32:33 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     Marcus Folkesson <marcus.folkesson@...il.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Wim Van Sebroeck <wim@...ana.be>
Cc:     linux-arm-kernel@...ts.infradead.org,
        linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] watchdog: coh901327: make license text and module licence
 match

On 02/10/2018 01:27 AM, Marcus Folkesson wrote:
> Licence text is specifying "GPLv2" but the MODULE_LICENSE is set to "GPLv2
> or later".
> 
> See include/linux/module.h:
> "GPL"				[GNU Public License v2 or later]
> "GPL v2"			[GNU Public License v2]
> 
> When on it, add SPDX identifier tag.
> 
> Signed-off-by: Marcus Folkesson <marcus.folkesson@...il.com>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> ---
>   drivers/watchdog/coh901327_wdt.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/watchdog/coh901327_wdt.c b/drivers/watchdog/coh901327_wdt.c
> index 5d8eb9a30879..7b71e0a3e6cc 100644
> --- a/drivers/watchdog/coh901327_wdt.c
> +++ b/drivers/watchdog/coh901327_wdt.c
> @@ -1,8 +1,8 @@
> +// SPDX-License-Identifier: GPL-2.0
>   /*
>    * coh901327_wdt.c
>    *
>    * Copyright (C) 2008-2009 ST-Ericsson AB
> - * License terms: GNU General Public License (GPL) version 2
>    * Watchdog driver for the ST-Ericsson AB COH 901 327 IP core
>    * Author: Linus Walleij <linus.walleij@...ricsson.com>
>    */
> @@ -420,5 +420,5 @@ MODULE_DESCRIPTION("COH 901 327 Watchdog");
>   module_param(margin, uint, 0);
>   MODULE_PARM_DESC(margin, "Watchdog margin in seconds (default 60s)");
>   
> -MODULE_LICENSE("GPL");
> +MODULE_LICENSE("GPL v2");
>   MODULE_ALIAS("platform:coh901327-watchdog");
>