linux-kernel - Re: [PATCH 2/3] arm64: dts: rockchip: add cdn-dp node for rk3399.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6229682.fDmaELEjz4@phil>
Date:   Sat, 10 Feb 2018 17:16:45 +0100
From:   Heiko Stuebner <heiko@...ech.de>
To:     Enric Balletbo i Serra <enric.balletbo@...labora.com>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will.deacon@....com>,
        Brian Norris <briannorris@...omium.org>, groeck@...omium.org,
        devicetree@...r.kernel.org, linux-rockchip@...ts.infradead.org,
        linux-kernel@...r.kernel.org, Chris Zhong <zyw@...k-chips.com>
Subject: Re: [PATCH 2/3] arm64: dts: rockchip: add cdn-dp node for rk3399.

Hi Enric,

Am Mittwoch, 7. Februar 2018, 17:31:49 CET schrieb Enric Balletbo i Serra:
> From: Chris Zhong <zyw@...k-chips.com>
> 
> Add a node for the cdn DP controller which is embedded in the rk3399
> SoC.
> 
> Signed-off-by: Chris Zhong <zyw@...k-chips.com>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@...labora.com>
> ---
>  arch/arm64/boot/dts/rockchip/rk3399.dtsi | 50 ++++++++++++++++++++++++++++++++

It looks like there is no binding document at all for cdn-dp? At least
I couldn't find one and the original series also didn't seem to include one.

And while I don't see anything problematic right with the used properties
right now, I'd think we should really have a binding and give dt-maintainers
a chance to complain, before adding devicetree nodes based on it.

I'd guess a mostly usable binding doc should already sit in the chromeos
tree, which you could base a v2 of this series on?

Thanks
Heiko